From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932318Ab0CDU7J (ORCPT ); Thu, 4 Mar 2010 15:59:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7282 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919Ab0CDU7I (ORCPT ); Thu, 4 Mar 2010 15:59:08 -0500 Message-ID: <4B901F06.1010106@redhat.com> Date: Thu, 04 Mar 2010 15:58:46 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc11 Thunderbird/3.0.3 MIME-Version: 1.0 To: Peter Zijlstra CC: mingo@elte.hu, linux-kernel@vger.kernel.org, paulus@samba.org, eranian@google.com, robert.richter@amd.com, fweisbec@gmail.com, Arnaldo Carvalho de Melo , Yanmin Zhang Subject: Re: [PATCH 09/14] perf, x86: use LBR for PEBS IP+1 fixup References: <20100304140046.596569763@chello.nl> <20100304140100.619375431@chello.nl> <4B8FDE16.3050403@redhat.com> <1267725262.25158.206.camel@laptop> <4B901E23.4080701@redhat.com> In-Reply-To: <4B901E23.4080701@redhat.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masami Hiramatsu wrote: > Peter Zijlstra wrote: >> On Thu, 2010-03-04 at 11:21 -0500, Masami Hiramatsu wrote: >>> Peter Zijlstra wrote: >> >>>> +#define perf_misc_flags(regs) \ >>>> +({ int misc = 0; \ >>>> + if (user_mode(regs)) \ >>>> + misc |= PERF_RECORD_MISC_USER; \ >>>> + else \ >>>> + misc |= PERF_RECORD_MISC_KERNEL; \ >>>> + if (regs->flags & PERF_EFLAGS_EXACT) \ >>>> + misc |= PERF_RECORD_MISC_EXACT; \ >>>> + misc; }) >>>> + >>>> +#define perf_instruction_pointer(regs) ((regs)->ip) >>> >>> Hmm, why don't you use instruction_pointer() defined in asm/ptrace.h? >>> And I couldn't find any user of this macro in this patch... >> >> perf_instruction_pointer() is used in kernel/perf_event.c, and yeah I >> could have used instruction_pointer() but that's yet another wrapper. >> >> Anyway, Yanmin is poking at doing kvm-guest profiling and will likely >> rewrite all of the perf_misc() and perf_instruction_pointer() stuff >> soon. > > Hmm, still I can't find where it is used (in your patches). Ah, OK. that is already used in kernel/perf_event.c and the patch overwrites one defined in include/linux/perf_event.h. Reviewed-by: Masami Hiramatsu Thank you, -- Masami Hiramatsu e-mail: mhiramat@redhat.com