public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Denis Turischev <denis@compulab.co.il>
Subject: [PATCH -next] mfd/lpc_sch: fix related depends/selects, fix build error
Date: Fri, 05 Mar 2010 09:43:06 -0800	[thread overview]
Message-ID: <4B9142AA.9040801@oracle.com> (raw)
In-Reply-To: <20100305181358.9adfe089.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle.com>

LPC_SCH is selected by GPI_SCH and I2C_ISCH, even when PCI is not
enabled, but LPC_SCH depends on PCI, so make GPI_SCH and I2C_ISCH
also depend on PCI.

Those 2 selects also need to select what LPC_SCH selects,
since kconfig does not follow selects.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Denis Turischev <denis@compulab.co.il>
---
 drivers/gpio/Kconfig       |    3 ++-
 drivers/i2c/busses/Kconfig |    2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

--- linux-next-20100305.orig/drivers/gpio/Kconfig
+++ linux-next-20100305/drivers/gpio/Kconfig
@@ -87,7 +87,8 @@ config GPIO_VR41XX
 
 config GPIO_SCH
 	tristate "Intel SCH GPIO"
-	depends on GPIOLIB
+	depends on GPIOLIB && PCI
+	select MFD_CORE
 	select LPC_SCH
 	help
 	  Say yes here to support GPIO interface on Intel Poulsbo SCH.
--- linux-next-20100305.orig/drivers/i2c/busses/Kconfig
+++ linux-next-20100305/drivers/i2c/busses/Kconfig
@@ -105,6 +105,8 @@ config I2C_I801
 
 config I2C_ISCH
 	tristate "Intel SCH SMBus 1.0"
+	depends on PCI
+	select MFD_CORE
 	select LPC_SCH
 	help
 	  Say Y here if you want to use SMBus controller on the Intel SCH

-- 
~Randy

  reply	other threads:[~2010-03-05 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05  7:13 linux-next: Tree for March 5 Stephen Rothwell
2010-03-05 17:43 ` Randy Dunlap [this message]
2010-03-05 18:16   ` [PATCH -next] mfd/lpc_sch: fix related depends/selects, fix build error Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9142AA.9040801@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=denis@compulab.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox