From: Randy Dunlap <randy.dunlap@oracle.com>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, david@fromorbit.com
Subject: Re: UML XFS link error list_sort
Date: Sat, 06 Mar 2010 19:25:10 -0800 [thread overview]
Message-ID: <4B931C96.7070703@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1003062118240.19862@parag-laptop>
Parag Warudkar wrote:
> Hi Dave
>
> While building today's git for CONFIG_UML, I got a link error (list_sort
> undefined) for xfs.ko.
>
> Currently I am working around it with the below hack. Not sure the right
> thing to do would be some where at the arch level for UML or if the below
> would be appropriate.
>
> Parag
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index b4769e4..2905cda 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -94,6 +94,8 @@ xfs-y += xfs_alloc.o \
>
> xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
>
> +xfs-$(CONFIG_UML) += ../../lib/list_sort.o
> +
> # Objects in linux/
> xfs-y += $(addprefix $(XFS_LINUX)/, \
> kmem.o \
> --
I posted a patch for xfs to select LIST_SORT (kconfig symbol)
so that the library is built for it (xfs).
next prev parent reply other threads:[~2010-03-07 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 2:28 UML XFS link error list_sort Parag Warudkar
2010-03-07 3:25 ` Randy Dunlap [this message]
2010-03-07 10:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B931C96.7070703@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=parag.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox