From: "H. Peter Anvin" <hpa@zytor.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Daniel Taylor <Daniel.Taylor@wdc.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] msdos: add support for large disks
Date: Sun, 07 Mar 2010 15:03:18 -0800 [thread overview]
Message-ID: <4B9430B6.701@zytor.com> (raw)
In-Reply-To: <876358iehd.fsf@devron.myhome.or.jp>
On 03/07/2010 02:59 AM, OGAWA Hirofumi wrote:
> This part is broken. If "size" is smaller than minimum blocksize (note,
> "size" is number of 512b, not number of blocksize), we can't read any
> block after all (it is handled as outside of i_size by bdev).
>
> Peter (or someone) know what do we want to in here? This is on extended
> partition itself (e.g. if sda1 sda2<sda5 sda6>, it's the size of sda2)
We should presumably set it to one logical sector, regardless of size.
Either that, or the offset of the lowest contained partition.
> [BTW, it seems subtypes stuff is not thinking about sector size> 512b...]
Much else isn't, either. With the exception of some MO disks, it was
nearly unheard of for 20 years.
-hpa
next prev parent reply other threads:[~2010-03-07 23:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 3:17 [PATCH] msdos: add support for large disks Daniel Taylor
2010-03-01 22:13 ` Andrew Morton
2010-03-03 14:02 ` OGAWA Hirofumi
2010-03-03 22:50 ` Daniel Taylor
2010-03-03 23:05 ` H. Peter Anvin
2010-03-03 23:24 ` Daniel Taylor
2010-03-04 0:17 ` H. Peter Anvin
2010-03-04 9:18 ` OGAWA Hirofumi
2010-03-04 15:29 ` H. Peter Anvin
2010-03-07 10:59 ` OGAWA Hirofumi
2010-03-07 23:03 ` H. Peter Anvin [this message]
2010-03-08 0:09 ` OGAWA Hirofumi
2010-03-08 0:12 ` H. Peter Anvin
2010-03-08 9:36 ` OGAWA Hirofumi
2010-03-10 15:48 ` [PATCH 1/2] fs/partitions/msdos: " OGAWA Hirofumi
2010-03-10 15:51 ` [PATCH 2/2] fs/partition/msdos: Fix unusable extended partition for > 512B sector OGAWA Hirofumi
2010-03-10 23:16 ` Daniel Taylor
2010-03-11 11:57 ` OGAWA Hirofumi
2010-03-11 21:25 ` Daniel Taylor
2010-03-11 21:58 ` H. Peter Anvin
2010-03-11 22:06 ` Daniel Taylor
2010-03-11 22:09 ` H. Peter Anvin
2010-03-12 23:44 ` Andrew Morton
2010-03-11 22:17 ` OGAWA Hirofumi
2010-03-11 22:27 ` H. Peter Anvin
2010-03-11 22:40 ` OGAWA Hirofumi
2010-03-10 23:12 ` [PATCH 1/2] fs/partitions/msdos: add support for large disks Daniel Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9430B6.701@zytor.com \
--to=hpa@zytor.com \
--cc=Daniel.Taylor@wdc.com \
--cc=akpm@linux-foundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox