* [PATCH] OPTPROBES: Don't default to y in Kconfig
@ 2010-03-08 23:07 Dieter Ries
2010-03-09 15:57 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Dieter Ries @ 2010-03-08 23:07 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, linux-kernel, Dieter Ries
CONFIG_OPTPROBES should not default to y while still being flagged
EXPERIMENTAL.
Signed-off-by: Dieter Ries <mail@dieterries.net>
---
arch/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/Kconfig b/arch/Kconfig
index e5eb133..57710f7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -43,7 +43,7 @@ config KPROBES
config OPTPROBES
bool "Kprobes jump optimization support (EXPERIMENTAL)"
- default y
+ default n
depends on KPROBES
depends on !PREEMPT
depends on HAVE_OPTPROBES
--
1.7.0.rc0.76.g43960
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] OPTPROBES: Don't default to y in Kconfig
2010-03-08 23:07 [PATCH] OPTPROBES: Don't default to y in Kconfig Dieter Ries
@ 2010-03-09 15:57 ` Masami Hiramatsu
2010-03-11 13:15 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2010-03-09 15:57 UTC (permalink / raw)
To: Dieter Ries; +Cc: Ingo Molnar, linux-kernel
Dieter Ries wrote:
> CONFIG_OPTPROBES should not default to y while still being flagged
> EXPERIMENTAL.
Hm, OK, indeed it still needs some more user tests.
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Signed-off-by: Dieter Ries <mail@dieterries.net>
> ---
> arch/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index e5eb133..57710f7 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -43,7 +43,7 @@ config KPROBES
>
> config OPTPROBES
> bool "Kprobes jump optimization support (EXPERIMENTAL)"
> - default y
> + default n
> depends on KPROBES
> depends on !PREEMPT
> depends on HAVE_OPTPROBES
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OPTPROBES: Don't default to y in Kconfig
2010-03-09 15:57 ` Masami Hiramatsu
@ 2010-03-11 13:15 ` Ingo Molnar
2010-03-11 22:21 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2010-03-11 13:15 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Dieter Ries, linux-kernel
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Dieter Ries wrote:
> > CONFIG_OPTPROBES should not default to y while still being flagged
> > EXPERIMENTAL.
>
> Hm, OK, indeed it still needs some more user tests.
>
> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Well, since this is a prime time optimization i'd rather see the Kconfig value
eliminated and the optimization to become unconditional. (if it doesnt work
somewhere then it should be fixed)
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OPTPROBES: Don't default to y in Kconfig
2010-03-11 13:15 ` Ingo Molnar
@ 2010-03-11 22:21 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2010-03-11 22:21 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Dieter Ries, linux-kernel
Ingo Molnar wrote:
>
> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
>> Dieter Ries wrote:
>>> CONFIG_OPTPROBES should not default to y while still being flagged
>>> EXPERIMENTAL.
>>
>> Hm, OK, indeed it still needs some more user tests.
>>
>> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Well, since this is a prime time optimization i'd rather see the Kconfig value
> eliminated and the optimization to become unconditional. (if it doesnt work
> somewhere then it should be fixed)
OK, that will be good for finding bugs. :)
Thank you,
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-11 22:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-08 23:07 [PATCH] OPTPROBES: Don't default to y in Kconfig Dieter Ries
2010-03-09 15:57 ` Masami Hiramatsu
2010-03-11 13:15 ` Ingo Molnar
2010-03-11 22:21 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).