public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: Tomas Dabasinskas <tomas.it@gmail.com>
Cc: gregkh@suse.de, abraham.manu@gmail.com, davilla@4pi.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: crystalhd: fixed white spaces and brace coding in crystalhd_hw.c
Date: Wed, 10 Mar 2010 10:38:18 -0500	[thread overview]
Message-ID: <4B97BCEA.1000101@redhat.com> (raw)
In-Reply-To: <1268214661-12992-1-git-send-email-tomas.it@gmail.com>

On 03/10/2010 04:51 AM, Tomas Dabasinskas wrote:

 > This is a patch to the crystalhd_hw.c file that fixes up a white
 > space and brace warnings found by the checkpatch.pl tool
 >
 > Signed-off-by: Tomas Dabasinskas <tomas.it@gmail.com>

Acked-by: Jarod Wilson <jarod@redhat.com>

Although, ultimately, I'm planning to replace all the BCMLOG bits anyway 
with dev_foo printk wrappers. Just haven't had time to yet.

--jarod


> ---
>   drivers/staging/crystalhd/crystalhd_hw.c |   29 ++++++++++++-----------------
>   1 files changed, 12 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c
> index 01819d3..772da05 100644
> --- a/drivers/staging/crystalhd/crystalhd_hw.c
> +++ b/drivers/staging/crystalhd/crystalhd_hw.c
> @@ -431,7 +431,7 @@ static void crystalhd_hw_delete_ioqs(struct crystalhd_hw *hw)
>   	if (!hw)
>   		return;
>
> -	BCMLOG(BCMLOG_DBG, "Deleting IOQs \n");
> +	BCMLOG(BCMLOG_DBG, "Deleting IOQs\n");
>   	crystalhd_hw_delete_ioq(hw->adp, hw->tx_actq);
>   	crystalhd_hw_delete_ioq(hw->adp, hw->tx_freeq);
>   	crystalhd_hw_delete_ioq(hw->adp, hw->rx_actq);
...

-- 
Jarod Wilson
jarod@redhat.com

      reply	other threads:[~2010-03-10 15:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10  9:51 [PATCH] Staging: crystalhd: fixed white spaces and brace coding in crystalhd_hw.c This is a patch to the crystalhd_hw.c file that fixes up a white space and brace warnings found by the checkpatch.pl tool Signed-off-by: Tomas Dabasinskas <tomas.it@gmail.com> Tomas Dabasinskas
2010-03-10 15:38 ` Jarod Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B97BCEA.1000101@redhat.com \
    --to=jarod@redhat.com \
    --cc=abraham.manu@gmail.com \
    --cc=davilla@4pi.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.it@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox