From: Randy Dunlap <rdunlap@xenotime.net>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Subject: [PATCH -mmotm] leds: fix net5501 kconfig
Date: Wed, 10 Mar 2010 11:43:34 -0800 [thread overview]
Message-ID: <4B97F666.9020709@xenotime.net> (raw)
In-Reply-To: <201003100342.o2A3gKvA022440@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
LEDS_NET5501 selects LEDS_TRIGGER_DEFAULT_ON even when the symbol
LEDS_TRIGGERS is not enabled. This causes build errors, so make
LEDS_NET5501 depend on LEDS_TRIGGERS to prevent the build errors.
drivers/leds/ledtrig-default-on.c:25: error: variable 'defon_led_trigger' has initializer but incomplete type
drivers/leds/ledtrig-default-on.c:26: error: unknown field 'name' specified in initializer
drivers/leds/ledtrig-default-on.c:26: warning: excess elements in struct initializer
drivers/leds/ledtrig-default-on.c:26: warning: (near initialization for 'defon_led_trigger')
drivers/leds/ledtrig-default-on.c:27: error: unknown field 'activate' specified in initializer
drivers/leds/ledtrig-default-on.c:27: warning: excess elements in struct initializer
drivers/leds/ledtrig-default-on.c:27: warning: (near initialization for 'defon_led_trigger')
drivers/leds/ledtrig-default-on.c:32: error: implicit declaration of function 'led_trigger_register'
drivers/leds/ledtrig-default-on.c:37: error: implicit declaration of function 'led_trigger_unregister'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
---
drivers/leds/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- mmotm-2010-0309-1915.orig/drivers/leds/Kconfig
+++ mmotm-2010-0309-1915/drivers/leds/Kconfig
@@ -69,7 +69,8 @@ config LEDS_NET48XX
config LEDS_NET5501
tristate "LED Support for Soekris net5501 series Error LED"
- depends on LEDS_CLASS && LEDS_GPIO_PLATFORM && GPIO_CS5535
+ depends on LEDS_CLASS && LEDS_TRIGGERS
+ depends on LEDS_GPIO_PLATFORM && GPIO_CS5535
select LEDS_TRIGGER_DEFAULT_ON
default n
help
next prev parent reply other threads:[~2010-03-10 19:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 3:16 mmotm 2010-03-09-19-15 uploaded akpm
2010-03-10 19:43 ` Randy Dunlap [this message]
2010-03-10 19:57 ` mmotm 2010-03-09-19-15: Lot of scheduling while atomic warnings related to RCU Mel Gorman
2010-03-10 20:21 ` Andrew Morton
2010-03-10 20:34 ` Mel Gorman
2010-03-10 20:32 ` Neil Horman
2010-03-11 22:30 ` Andi Kleen
2010-03-12 0:09 ` nhorman
2010-03-12 11:46 ` Mel Gorman
2010-03-12 15:29 ` Neil Horman
2010-03-12 15:41 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B97F666.9020709@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=gurligebis@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox