From: Michael Tokarev <mjt@tls.msk.ru>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-aio@kvack.org, Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: aio: compat_ioctl issue?
Date: Thu, 11 Mar 2010 22:10:26 +0300 [thread overview]
Message-ID: <4B994022.6030703@msgid.tls.msk.ru> (raw)
In-Reply-To: <x49wrxij11s.fsf@segfault.boston.devel.redhat.com>
Jeff Moyer wrote:
[]
> Yeah, whoops. I built the libaio test harness using -m32 and this patch
> works for me. Would you mind giving it a try?
It appears to work here so far. I did not run massive i/o test suite
but it now passes basic multiple kernel unpacking in parallel tests
(before it didnt' even recognize the partition table).
So the patch - at least basically - works.
Except that we now have code duplication in kernel. Look at
fs/compat.c:compat_do_readv_writev() - it does the same as
compat_rw_copy_check_uvector() plus a bit more. I guess it
is a good idea to use compat_rw_copy_check_uvector() in
compat_do_readv_writev() to build the compat vectors...
Thank you for the patch and the fix!
/mjt
next prev parent reply other threads:[~2010-03-11 19:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 21:38 aio: compat_ioctl issue? Michael Tokarev
2010-03-08 21:43 ` Jeff Moyer
2010-03-08 21:50 ` Michael Tokarev
2010-03-08 22:25 ` Jeff Moyer
2010-03-08 22:32 ` Michael Tokarev
2010-03-08 22:41 ` Michael Tokarev
2010-03-11 16:06 ` Jeff Moyer
2010-03-11 19:10 ` Michael Tokarev [this message]
2010-03-11 19:13 ` Jeff Moyer
2010-03-11 19:46 ` Michael Tokarev
2010-03-11 19:57 ` Jeff Moyer
2010-03-11 20:13 ` Michael Tokarev
2010-03-16 18:52 ` Jeff Moyer
2010-03-16 20:36 ` Michael Tokarev
2010-03-16 20:44 ` Jeff Moyer
2010-04-28 18:00 ` Avi Kivity
2010-04-28 18:11 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B994022.6030703@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox