From: Tejun Heo <tj@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [RFC] remove implicit slab.h inclusion from percpu.h
Date: Fri, 12 Mar 2010 07:33:18 +0900 [thread overview]
Message-ID: <4B996FAE.3030102@kernel.org> (raw)
In-Reply-To: <20100311174821.GA5123@x200>
Hello,
On 03/12/2010 02:48 AM, Alexey Dobriyan wrote:
>> So, what do you guys think? Probably-the-right-thing-to-do >544 file
>> patch or somewhat-ugly-but-let's-worry-about-it-tommorrow two file
>> patch?
>
> You can include slab.h only for UP case.
>
> Since everyone tests on allmodconfig which has SMP=y, configuration
> will be more strict wrt headers, and compile breakages amount
> negligible.
But that wouldn't change anything about having to do an oneshot huge
change, right? And, if we're gonna do that anyway, I think it would
be better to remove the implicit dependency for UP case too so that
for example slab.h in this case doesn't have to do ifdef on CONFIG_SMP
before using percpu accessors.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-03-11 22:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 14:56 [RFC] remove implicit slab.h inclusion from percpu.h Tejun Heo
2010-03-11 17:48 ` Alexey Dobriyan
2010-03-11 22:33 ` Tejun Heo [this message]
2010-03-16 4:27 ` Tejun Heo
2010-03-16 6:17 ` Ingo Molnar
2010-03-16 6:54 ` Tejun Heo
2010-03-16 7:44 ` Tejun Heo
2010-03-16 7:57 ` Ingo Molnar
2010-03-16 8:32 ` Alexey Dobriyan
2010-03-16 9:11 ` Pekka Enberg
2010-03-16 7:49 ` Ingo Molnar
2010-03-16 6:58 ` Pekka Enberg
2010-03-16 7:15 ` Alexey Dobriyan
2010-03-16 7:56 ` Pekka Enberg
2010-03-16 8:23 ` Alexey Dobriyan
2010-03-16 9:06 ` Pekka Enberg
2010-03-16 8:25 ` Ingo Molnar
2010-03-16 7:14 ` Alexey Dobriyan
2010-03-16 8:16 ` Ingo Molnar
2010-03-16 16:16 ` Christoph Lameter
2010-03-16 22:57 ` Tejun Heo
2010-03-17 16:34 ` Christoph Lameter
2010-03-17 17:14 ` Lee Schermerhorn
2010-03-17 19:54 ` Christoph Lameter
2010-03-17 23:00 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B996FAE.3030102@kernel.org \
--to=tj@kernel.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox