From: Avi Kivity <avi@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: ying.huang@intel.com, akpm@linux-foundation.org,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [BUGFIX] Fix AES-NI CTR optimization compiling failure with gas 2.16.1
Date: Fri, 12 Mar 2010 10:44:58 +0200 [thread overview]
Message-ID: <4B99FF0A.1030700@redhat.com> (raw)
In-Reply-To: <20100312.004202.27822414.davem@davemloft.net>
On 03/12/2010 10:42 AM, David Miller wrote:
> From: Avi Kivity<avi@redhat.com>
> Date: Fri, 12 Mar 2010 10:37:33 +0200
>
>
>> Eventually you'll port the entire assembler into macros, as
>> instructions are introduced more frequently that people upgrade their
>> assemblers. Maybe we should disable the new features and warn people
>> (and distros) to upgrade their tools instead.
>>
> I totally and completely disagree.
>
> It would have taken more than a year to get Niagara cpu support out to
> people if I had done what you are suggesting.
>
Strange, that people can install a new kernel, but not a new assembler.
> And here we're talking about one instruction in one specialized case
> in a very piece of crypto module assembler.
>
If it were one place, I'd agree, but there are more. kvm for example
also uses .byte instead of the actual instructions.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-03-12 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 7:01 [BUGFIX] Fix AES-NI CTR optimization compiling failure with gas 2.16.1 Huang Ying
2010-03-12 8:37 ` Avi Kivity
2010-03-12 8:42 ` David Miller
2010-03-12 8:44 ` Avi Kivity [this message]
2010-03-12 8:50 ` David Miller
2010-03-12 9:33 ` Avi Kivity
2010-03-13 8:29 ` Herbert Xu
2010-03-23 21:23 ` Andrew Morton
2010-03-24 6:24 ` Huang Ying
2010-03-24 10:51 ` Andrew Morton
2010-03-24 13:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B99FF0A.1030700@redhat.com \
--to=avi@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox