From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933966Ab0CLPBA (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Mar 2010 10:01:00 -0500
Received: from mail.atmel.fr ([81.80.104.162]:36140 "EHLO atmel-es2.atmel.fr"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932343Ab0CLPA6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Mar 2010 10:00:58 -0500
Message-ID: <4B9A5718.2040500@atmel.com>
Date: Fri, 12 Mar 2010 16:00:40 +0100
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3
MIME-Version: 1.0
To: Benjamin Valentin <benpicco@zedat.fu-berlin.de>,
       linux-arm-kernel@lists.infradead.org
CC: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, dinuxbg@gmail.com
Subject: Re: [PATCH 1/2] Add support for Olimex SAM9-L9261 SBC
References: <20100312105817.4392b594@rechenknecht2k7> <20100312110032.2e57fdce@rechenknecht2k7>
In-Reply-To: <20100312110032.2e57fdce@rechenknecht2k7>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

First and foremost, thank you for doing this job. It is indeed always a
good idea to submit work to the community.

Le 12/03/2010 11:00, Benjamin Valentin :

[..]

> diff -ru linux-2.6.34-rc1/drivers/video/atmel_lcdfb.c linux-2.6.34-rc1-olimex/drivers/video/atmel_lcdfb.c
> --- linux-2.6.34-rc1/drivers/video/atmel_lcdfb.c	2010-02-24 19:52:17.000000000 +0100
> +++ linux-2.6.34-rc1-olimex/drivers/video/atmel_lcdfb.c	2010-02-25 16:11:58.665578876 +0100

In a separate patch please. You will also have to sent it to
linux-fbdev-devel mailing list.

> @@ -21,6 +21,7 @@
>  #include <mach/board.h>
>  #include <mach/cpu.h>
>  #include <mach/gpio.h>
> +#include <asm/mach-types.h>
>  
>  #include <video/atmel_lcdc.h>
>  
> @@ -548,6 +549,10 @@
>  	if (!(info->var.sync & FB_SYNC_VERT_HIGH_ACT))
>  		value |= ATMEL_LCDC_INVFRAME_INVERTED;
>  
> +	if (machine_is_sam9_l9261()) {
> +		value |= ATMEL_LCDC_INVCLK_INVERTED;
> +	}
> +

Anyway, I think the driver is not the place to add this configuration.
You will have to configure it in the board file:
default_lcdcon2 field of the atmel_lcdfb_info structure.
Check the arch/avr32/boards/atngw100/mrmr.c file as an example.

>  	switch (info->var.bits_per_pixel) {
>  		case 1:	value |= ATMEL_LCDC_PIXELSIZE_1; break;
>  		case 2: value |= ATMEL_LCDC_PIXELSIZE_2; break;
> 

Bye,
-- 
Nicolas Ferre