public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Jan Engelhardt <jengelh@medozas.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>, Nick Piggin <npiggin@suse.de>
Subject: Re: page_to_nid not linked in on PAE
Date: Fri, 12 Mar 2010 14:33:45 -0800	[thread overview]
Message-ID: <4B9AC149.1010507@linux.intel.com> (raw)
In-Reply-To: <1268423424.2793.21.camel@sbs-t61.sc.intel.com>


> Jan, Even with out using the PG_head, PG_tail, PG_uncached and
> PG_hwpoison, by allowing the NODES_SHIFT to have a maximum value of 9 on
> 32bit kernel, can still result in the page flags to runout and result in
> this problem. Best solution for now is to limit the NODES_SHIFT to 5. I
> don't know of any platforms that have>  32nodes and where we care about
> 32bit linux kernel. So it should be ok as a fix. If someone in future
> cares about>  32 nodes for 32bit kernel, then we can think of a better
> solution. Do you agree? I copied Andi/Nick for their eyes aswell on
> this.

Seems like the right approach to me. Although it might be better to
use 1 3 or 1..4 or so, just in case someone else adds more page bits
later (I'm sure it'll happen again). Even 8 nodes should be plenty for
32bit.

Acked-by: Andi Kleen <ak@linux.intel.com>

-Andi


  reply	other threads:[~2010-03-12 22:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 12:32 page_to_nid not linked in on PAE Jan Engelhardt
2010-03-10 10:30 ` Jan Engelhardt
2010-03-12 19:50   ` Suresh Siddha
2010-03-12 22:33     ` Andi Kleen [this message]
2010-03-13  0:34       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9AC149.1010507@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jengelh@medozas.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox