From: Larry Finger <Larry.Finger@lwfinger.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>, Tejun Heo <tj@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70
Date: Sat, 13 Mar 2010 16:55:15 -0600 [thread overview]
Message-ID: <4B9C17D3.5080402@lwfinger.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1003131426480.3719@i5.linux-foundation.org>
On 03/13/2010 04:32 PM, Linus Torvalds wrote:
>
>
> On Sat, 13 Mar 2010, Larry Finger wrote:
>>
>> Commit a2db6842873c8e5a70652f278d469128cb52db70 changed the way that
>> sysfs attributes are handled. With lockdep checking enabled, a firmware
>> loading request from b43 generates the following BUG:
>>
>> BUG: key ffff8800b85f4870 not in .data!
>> ------------[ cut here ]------------
>> WARNING: at kernel/lockdep.c:2706 lockdep_init_map+0x236/0x5d0()
>
> I don't think we can fix these problems this way.
>
> Lookie here:
>
> [torvalds@i5 linux]$ git grep sysfs_create_bin_file | wc
> 68 319 5999
> [torvalds@i5 linux]$ git grep sysfs_bin_attr_init | wc
> 8 24 522
>
> and you sent in patches to fix _two_ of the remaining 60 cases.
Those are the two that showed up on my machine, and as Jiri says, not all 68
will be needed. I need them to see any lockdep problems on the driver I'm
developing. I'll watch for developments.
Larry
prev parent reply other threads:[~2010-03-13 22:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 19:36 [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70 Larry Finger
2010-03-13 22:32 ` Linus Torvalds
2010-03-13 22:39 ` Jiri Kosina
2010-03-13 22:57 ` Linus Torvalds
2010-03-14 3:57 ` Eric W. Biederman
2010-03-14 5:46 ` Linus Torvalds
2010-03-14 6:59 ` Ingo Molnar
2010-03-14 17:20 ` Linus Torvalds
2010-03-14 18:11 ` Greg KH
2010-03-14 18:30 ` Eric W. Biederman
2010-03-14 18:38 ` Greg KH
2010-03-14 10:49 ` Wolfram Sang
2010-03-14 18:04 ` Linus Torvalds
2010-03-14 18:07 ` Linus Torvalds
2010-03-14 19:08 ` Eric W. Biederman
2010-03-15 0:48 ` Wolfram Sang
2010-03-15 0:20 ` Wolfram Sang
2010-03-15 0:29 ` [PATCH] init dynamic bin_attribute structures Wolfram Sang
2010-03-15 10:00 ` Jiri Kosina
2010-03-15 10:12 ` [rtc-linux] " Wolfram Sang
2010-03-15 18:47 ` Linus Torvalds
2010-03-13 22:55 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9C17D3.5080402@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox