From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Pavel Machek <pavel@ucw.cz>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Lars Lindley <lindley@coyote.org>,
gregkh@suse.de, diegoliz@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] staging/winbond: camelCase should be fixed
Date: Sun, 14 Mar 2010 11:46:57 +0200 [thread overview]
Message-ID: <4B9CB091.1040108@cs.helsinki.fi> (raw)
In-Reply-To: <20100313112005.GB2192@elf.ucw.cz>
Pavel Machek wrote:
>> (BTW, winbond/README alias winbond/TODO doesn't mention it, but another
>> (trivial) step is going to be to change variable names and function
>> names from CamelCase to lower_case spelling.)
>
> Yes.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> diff --git a/drivers/staging/winbond/README b/drivers/staging/winbond/README
> index cb944e4..2771024 100644
> --- a/drivers/staging/winbond/README
> +++ b/drivers/staging/winbond/README
> @@ -2,6 +2,7 @@ TODO:
> - sparse cleanups
> - checkpatch cleanups
> - kerneldoc cleanups
> + - fix severeCamelCaseInfestation
> - remove typedefs
> - remove unused ioctls
> - use cfg80211 for regulatory stuff
>
>
next prev parent reply other threads:[~2010-03-14 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 21:45 [PATCH] staging: winbond: Formatting, whitespace etc in mds.c I fixed most of the problems found by checkpatch.pl. Some long lines are left and some KERN_.. Signed-off-by: Lars Lindley <lindley@coyote.org> Lars Lindley
2010-03-13 6:31 ` Pavel Machek
2010-03-13 10:08 ` Lars Lindley
2010-03-13 10:12 ` Pavel Machek
2010-03-13 10:37 ` Stefan Richter
2010-03-13 11:20 ` [patch] staging/winbond: camelCase should be fixed Pavel Machek
2010-03-14 9:46 ` Pekka Enberg [this message]
2010-04-27 20:47 ` [PATCH] staging: winbond: Formatting, whitespace etc in mds.c I fixed most of the problems found by checkpatch.pl. Some long lines are left and some KERN_.. Signed-off-by: Lars Lindley <lindley@coyote.org> Greg KH
2010-04-27 20:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9CB091.1040108@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=diegoliz@gmail.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox