From: Tilman Schmidt <t.schmidt@phoenixsoftware.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: should new kfifo implementation really be exporting that much?
Date: Sun, 14 Mar 2010 17:37:37 +0100 [thread overview]
Message-ID: <4B9D10D1.1060602@phoenixsoftware.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1003141053380.5987@localhost>
Am 14.03.2010 15:57 schrieb Robert P. J. Day:
> as a short followup, kfifo.h strongly implies that a lot of the
> above shouldn't be exported:
>
> ...
> /*
> * __kfifo_in_... internal functions for put date into the fifo
> * do not call it directly, use kfifo_in_rec() instead
> */
> ...
>
> anyway, you get the idea. it would seem that a lot of those EXPORTs
> should be removed, no?
If you look at kfifo_in_rec(), it's a static inline void function
defined in kfifo.h and which calls __kfifo_in_generic() or
__kfifo_in_rec(). I don't think you'll be able to make that work
without exporting those functions.
HTH
T.
next prev parent reply other threads:[~2010-03-14 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 13:32 should new kfifo implementation really be exporting that much? Robert P. J. Day
2010-03-14 14:57 ` Robert P. J. Day
2010-03-14 16:37 ` Tilman Schmidt [this message]
2010-03-14 16:49 ` Robert P. J. Day
2010-03-21 9:32 ` Jon Masters
2010-03-22 14:32 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9D10D1.1060602@phoenixsoftware.de \
--to=t.schmidt@phoenixsoftware.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox