Re: [patch] x86: handle legacy PIC interrupts on all the cpu's

Yinghai Lu
2010-03-15T22:16:47Z

On 03/15/2010 03:56 PM, Suresh Siddha wrote:
> On Mon, 2010-03-15 at 14:51 -0700, Yinghai Lu wrote:
>>> + for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
>>> + if (!IO_APIC_IRQ(irq))
>>> + per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
>>
>> seems those three lines are not needed...
>
> Those are needed for !CONFIG_X86_IO_APIC case.
>
then we can have

+#ifndef CONFIG_X86_IO_APIC
+ for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
+ per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
+#endif

then we don't punish most setup with ioapic controller.

Yinghai