From: Li Zefan <lizf@cn.fujitsu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Gui Jianfeng <GuiJianfeng@cn.fujitsu.com>,
Ben Blum <bblum@andrew.cmu.edu>,
LKML <linux-kernel@vger.kernel.org>,
"containers@lists.osdl.org" <containers@lists.osdl.org>
Subject: Re: [PATCH] block: make CONFIG_BLK_CGROUP visible
Date: Tue, 16 Mar 2010 09:36:41 +0800 [thread overview]
Message-ID: <4B9EE0A9.5010901@cn.fujitsu.com> (raw)
In-Reply-To: <20100315132149.GA21127@redhat.com>
>> ---help---
>> Generic block IO controller cgroup interface. This is the common
>> @@ -91,7 +92,7 @@ config BLK_CGROUP
>> to such task groups.
>>
>> config DEBUG_BLK_CGROUP
>> - bool
>> + bool "Block cgroup debugging help"
>
>
> Why are you making DEBUG_BLK_CGROUP this as a user visible/configurable
> option? This is already controlled by DEBUG_CFQ_IOSCHED. If you don't want
> the DEBUG overhead, just set DEBUG_CFQ_IOSCHED=n and DEBUG_BLK_CGROUP will
> not be selected? Making it user visible does not seem to be buying us
> anything?
>
Sounds reasonable. A minor question, since DEBUG_BLK_CGROUP is not
visible, the help message for this config is not visible too, so we
still keep it?
next prev parent reply other threads:[~2010-03-16 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 3:18 [PATCH] block: make CONFIG_BLK_CGROUP visible Li Zefan
2010-03-15 4:31 ` Ben Blum
2010-03-15 11:57 ` Jens Axboe
2010-03-16 1:42 ` Li Zefan
2010-03-16 7:56 ` Jens Axboe
2010-03-15 13:21 ` Vivek Goyal
2010-03-16 1:36 ` Li Zefan [this message]
2010-03-16 13:53 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9EE0A9.5010901@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=GuiJianfeng@cn.fujitsu.com \
--cc=bblum@andrew.cmu.edu \
--cc=containers@lists.osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox