From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Sheng Yang <sheng@linux.intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM MMU: check reserved bits only if CR4.PSE=1 or CR4.PAE=1
Date: Tue, 16 Mar 2010 08:15:32 +0200 [thread overview]
Message-ID: <4B9F2204.7050302@redhat.com> (raw)
In-Reply-To: <4B9F1F47.2040700@cn.fujitsu.com>
On 03/16/2010 08:03 AM, Xiao Guangrong wrote:
>
>> I think the only change is that is !is_pse(vcpu) we ignore bit 7?
>>
> If the vcpu is in PT32E_ROOT_LEVEL/PT64_ROOT_LEVEL mode, CR4.PAE
> is aways enabled, so what we need do is ignore bit7 if !is_pse(vcpu)
> under PT32_ROOT_LEVEL mode, right?
>
I think PAE will fault if bit7 is set and !is_pse(vcpu), but not sure.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-03-16 6:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 18:21 [PATCH] KVM MMU: check reserved bits only if CR4.PSE=1 or CR4.PAE=1 Xiao Guangrong
2010-03-16 5:31 ` Avi Kivity
2010-03-16 6:03 ` Xiao Guangrong
2010-03-16 6:15 ` Avi Kivity [this message]
2010-03-16 6:51 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9F2204.7050302@redhat.com \
--to=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox