From: Tejun Heo <tj@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Christoph Lameter <cl@linux-foundation.org>,
penberg@cs.helsinki.fi, adobriyan@gmail.com
Subject: Re: [RFC] remove implicit slab.h inclusion from percpu.h
Date: Tue, 16 Mar 2010 16:44:07 +0900 [thread overview]
Message-ID: <4B9F36C7.4020304@kernel.org> (raw)
In-Reply-To: <4B9F2B0A.70507@kernel.org>
Hello,
On 03/16/2010 03:54 PM, Tejun Heo wrote:
> Maybe a better way is to grab for slab API usages in .c files which
> don't have slab.h inclusion. If breaking the dependency is the way to
> go, I can definitely write up some scripts and do test builds on some
> archs. There sure will be some fallouts but I think it won't be too
> bad.
Hmmm... here are some interesting numbers. Not completely exact but
should give the general ballpark idea.
all .c files : 13999
.c files which use any of slab interface : 5603
.c files which include slab.h : 2519
.c files which include slab.h but don't use it : 577
.c files which use slab but don't include it : 3661
.c files with k[mzc]alloc/k[z]free usage : 5291
.c files with other slab interface usage : 356
C files which use k[mzc]alloc/k[z]free covers ~38% of all c files.
One possibility is to separate out those into kmalloc.h and make it
available universally via kernel.h.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-03-16 7:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 14:56 [RFC] remove implicit slab.h inclusion from percpu.h Tejun Heo
2010-03-11 17:48 ` Alexey Dobriyan
2010-03-11 22:33 ` Tejun Heo
2010-03-16 4:27 ` Tejun Heo
2010-03-16 6:17 ` Ingo Molnar
2010-03-16 6:54 ` Tejun Heo
2010-03-16 7:44 ` Tejun Heo [this message]
2010-03-16 7:57 ` Ingo Molnar
2010-03-16 8:32 ` Alexey Dobriyan
2010-03-16 9:11 ` Pekka Enberg
2010-03-16 7:49 ` Ingo Molnar
2010-03-16 6:58 ` Pekka Enberg
2010-03-16 7:15 ` Alexey Dobriyan
2010-03-16 7:56 ` Pekka Enberg
2010-03-16 8:23 ` Alexey Dobriyan
2010-03-16 9:06 ` Pekka Enberg
2010-03-16 8:25 ` Ingo Molnar
2010-03-16 7:14 ` Alexey Dobriyan
2010-03-16 8:16 ` Ingo Molnar
2010-03-16 16:16 ` Christoph Lameter
2010-03-16 22:57 ` Tejun Heo
2010-03-17 16:34 ` Christoph Lameter
2010-03-17 17:14 ` Lee Schermerhorn
2010-03-17 19:54 ` Christoph Lameter
2010-03-17 23:00 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9F36C7.4020304@kernel.org \
--to=tj@kernel.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox