From: Mike Christie <michaelc@cs.wisc.edu>
To: Jiri Slaby <jslaby@suse.cz>
Cc: James.Bottomley@suse.de, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
Jayamohan Kallickal <jayamohank@serverengines.com>
Subject: Re: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance
Date: Tue, 16 Mar 2010 13:10:53 -0500 [thread overview]
Message-ID: <4B9FC9AD.3000409@cs.wisc.edu> (raw)
In-Reply-To: <1268753039-17214-1-git-send-email-jslaby@suse.cz>
On 03/16/2010 10:23 AM, Jiri Slaby wrote:
> Stanse found that one error path in mgmt_invalidate_icds omits to unlock
> ctrl->mbox_lock. Fix that.
>
> Added in 756d29c8c7ed8887ed7d752371ce2f (Enable async mode for mcc rings)
> where the spinlock was moved.
>
> Signed-off-by: Jiri Slaby<jslaby@suse.cz>
> Cc: Jayamohan Kallickal<jayamohank@serverengines.com>
> Cc: James Bottomley<James.Bottomley@suse.de>
> ---
> drivers/scsi/be2iscsi/be_mgmt.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
> index 72617b6..e641922 100644
> --- a/drivers/scsi/be2iscsi/be_mgmt.c
> +++ b/drivers/scsi/be2iscsi/be_mgmt.c
> @@ -169,6 +169,7 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba,
> SE_DEBUG(DBG_LVL_1,
> "Failed to allocate memory for"
> "mgmt_invalidate_icds \n");
> + spin_unlock(&ctrl->mbox_lock);
> return -1;
> }
> nonemb_cmd.size = sizeof(struct invalidate_commands_params_in);
Looks good.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
next prev parent reply other threads:[~2010-03-16 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 15:23 [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance Jiri Slaby
2010-03-16 15:23 ` [PATCH 2/3] SCSI: lpfc, fix lock imbalances Jiri Slaby
2010-03-16 17:11 ` James Smart
2010-03-16 15:23 ` [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance Jiri Slaby
2010-03-16 20:23 ` [Suspected SPAM] " Giridhar Malavali
2010-03-16 18:10 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-16 20:48 [PATCH 1/3] SCSI: be2iscsi, " Jayamohan Kalickal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9FC9AD.3000409@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=jayamohank@serverengines.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox