public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-aio@kvack.org, Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: aio: compat_ioctl issue?
Date: Tue, 16 Mar 2010 23:36:00 +0300	[thread overview]
Message-ID: <4B9FEBB0.4020300@msgid.tls.msk.ru> (raw)
In-Reply-To: <x49d3z4t7yt.fsf@segfault.boston.devel.redhat.com>

Jeff Moyer wrote:
[]
> Sorry for taking so long on this.  I only tested the case where niovs >
> fast_segs, and I missed an obvious thing: I didn't assign the return
> pointer to the proper iovec.

There's no need to be sorry really.  Because, well, the whole thing isn't
quite useful anyway: running proper 64bit code is preferable ;)

I actually tried the thing, running a guest right now, which in turn is
running a quick benchmark and appears to perform quite good at it too.

> So, this patch should get you going.

Well, I already switched to 64bit kvm binary for my case, and actually
that one makes alot more sense anyway: there's no conversion like this
needed, and no 32<=>64bit mode switching either.  (Actually 32bit code
in this my case is slower elsewhere too).

By the way, how about the case when we've several {write,read}v in the
iocb array?  Will each use the same fast_segs array from the beginning,
overwriting data of previous iocb element? :)  Just... curious :)

Thank you for your support!

You can add my
Tested-By: Michael Tokarev <mjt@tls.msk.ru>
if you want.  Thanks!

/mjt

  reply	other threads:[~2010-03-16 20:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 21:38 aio: compat_ioctl issue? Michael Tokarev
2010-03-08 21:43 ` Jeff Moyer
2010-03-08 21:50   ` Michael Tokarev
2010-03-08 22:25     ` Jeff Moyer
2010-03-08 22:32       ` Michael Tokarev
2010-03-08 22:41         ` Michael Tokarev
2010-03-11 16:06           ` Jeff Moyer
2010-03-11 19:10             ` Michael Tokarev
2010-03-11 19:13               ` Jeff Moyer
2010-03-11 19:46               ` Michael Tokarev
2010-03-11 19:57                 ` Jeff Moyer
2010-03-11 20:13                   ` Michael Tokarev
2010-03-16 18:52                     ` Jeff Moyer
2010-03-16 20:36                       ` Michael Tokarev [this message]
2010-03-16 20:44                         ` Jeff Moyer
2010-04-28 18:00                           ` Avi Kivity
2010-04-28 18:11                             ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9FEBB0.4020300@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=jmoyer@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox