From: Jason Wessel <jason.wessel@windriver.com>
To: Greg KH <greg@kroah.com>
Cc: gregkh@suse.de, Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@linux.intel.com>,
Oliver Neukum <oliver@neukum.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/5] tty_port,usb-console: Fix usb serial consoleopen/close regression
Date: Tue, 16 Mar 2010 16:34:46 -0500 [thread overview]
Message-ID: <4B9FF976.1060508@windriver.com> (raw)
In-Reply-To: <20100316212337.GB31739@kroah.com>
On 03/16/2010 04:23 PM, Greg KH wrote:
> On Tue, Mar 16, 2010 at 04:05:42PM -0500, Jason Wessel wrote:
>> Commit e1108a63e10d344284011cccc06328b2cd3e5da3 ("usb_serial: Use the
>> shutdown() operation") breaks the ability to use a usb console
>> starting in 2.6.33. This was observed when using
>> console=ttyUSB0,115200 as a boot argument with an FTDI device. The
>> error is:
>>
>> ftdi_sio ttyUSB0: ftdi_submit_read_urb - failed submitting read urb, error -22
>>
>> The handling of the ASYNCB_INITIALIZED changed in 2.6.32 such that in
>> tty_port_shutdown() it always clears the flag if it is set. The fix
>> is to add a variable to the tty_port struct to indicate when the tty
>> port is a console.
>
> I've already applied this to my trees, right?
>
>
Correct. This is also in your tree. Patches 3-5 are not.
Jason.
next prev parent reply other threads:[~2010-03-16 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 21:05 [PATCH 0/5] V2 usb console improvements series Jason Wessel
2010-03-16 21:05 ` [PATCH 1/5] tty_port,usb-console: Fix usb serial console open/close regression Jason Wessel
2010-03-16 21:05 ` [PATCH 2/5] usb-serial: Use tty_port version of console instead of the usb_serial_port version Jason Wessel
2010-03-16 21:05 ` [PATCH 3/5] usb-console: pass baud from console to the initial tty open Jason Wessel
2010-03-16 21:05 ` [PATCH 4/5] usb-hcd,usb-console: poll hcd device to force usb console writes Jason Wessel
2010-03-16 21:05 ` [PATCH 5/5] usb-serialy,sysrq: Run the sysrq handler in a tasklet Jason Wessel
2010-03-16 21:46 ` [PATCH 4/5] usb-hcd,usb-console: poll hcd device to force usb console writes Greg KH
2010-03-17 9:08 ` Johan Hovold
2010-03-17 14:38 ` Alan Stern
2010-03-16 21:23 ` [PATCH 2/5] usb-serial: Use tty_port version of console instead of the usb_serial_port version Greg KH
2010-03-16 21:34 ` [PATCH 2/5] usb-serial: Use tty_port version of consoleinstead " Jason Wessel
2010-03-16 21:23 ` [PATCH 1/5] tty_port,usb-console: Fix usb serial console open/close regression Greg KH
2010-03-16 21:34 ` Jason Wessel [this message]
2010-03-17 14:30 ` [PATCH 0/5] V2 usb console improvements series Alan Stern
2010-03-17 14:46 ` Jason Wessel
2010-03-17 15:34 ` Alan Stern
2010-03-19 11:59 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9FF976.1060508@windriver.com \
--to=jason.wessel@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox