Re: [PATCH] KVM: cleanup kvm_get_dirty_log()

[Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>]

Takuya Yoshikawa wrote:
> Xiao Guangrong wrote:
>> Using bitmap_empty() to see whether memslot->dirty_bitmap is empty
>>
> 
> You can do this for arch specific get_dirty_log() too.

OK, i'll do it in the next version

> 
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
>> ---
>>  virt/kvm/kvm_main.c |    6 ++----
>>  1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index bcd08b8..497ae14 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -767,8 +767,7 @@ int kvm_get_dirty_log(struct kvm *kvm,
>>              struct kvm_dirty_log *log, int *is_dirty)
>>  {
>>      struct kvm_memory_slot *memslot;
>> -    int r, i;
>> -    int n;
>> +    int r, n;
>>      unsigned long any = 0;
> 
> any is no longer need to be unsigned long, if you do this?

Yeah, right, thanks for you point out.

Xiao