From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338Ab0CQGVd (ORCPT ); Wed, 17 Mar 2010 02:21:33 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:45542 "EHLO smtprelay-b12.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753264Ab0CQGVc (ORCPT ); Wed, 17 Mar 2010 02:21:32 -0400 X-Greylist: delayed 1115 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 Mar 2010 02:21:32 EDT X-SENDER-IP: [85.228.115.218] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtE/AK4NoEtV5HPaPGdsb2JhbACDC4RVkyIMAQEBATctpn+QI4EsgmBqBA X-IronPort-AV: E=Sophos;i="4.49,655,1262559600"; d="scan'208";a="51567362" Message-ID: <4BA0708C.8070402@pelagicore.com> Date: Wed, 17 Mar 2010 07:02:52 +0100 From: =?UTF-8?B?UmljaGFyZCBSw7ZqZm9ycw==?= User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: Anton Vorontsov CC: Andrew Morton , David Vrabel , Pierre Ossman , Ben Dooks , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] sdhci-pltfm: Do not print errors in case of an extended iomem size References: <20100316183400.GA24191@oksana.dev.rtsoft.ru> <20100316183430.GC25670@oksana.dev.rtsoft.ru> In-Reply-To: <20100316183430.GC25670@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/16/10 7:34 PM, Anton Vorontsov wrote: > Some hosts have an extended SDHCI iomem size, so the driver should > only print errors if the iomem size is less than 0x100. With this change you allow a bigger resource than we really need. I think you should also change request_mem_region and ioremap to only request and map the actual needed size. (0x100) > > Signed-off-by: Anton Vorontsov > --- > drivers/mmc/host/sdhci-pltfm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index 217b911..b6ee0d7 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -61,7 +61,7 @@ static int __devinit sdhci_pltfm_probe(struct platform_device *pdev) > goto err; > } > > - if (resource_size(iomem) != 0x100) > + if (resource_size(iomem) < 0x100) > dev_err(&pdev->dev, "Invalid iomem size. You may " > "experience problems.\n"); >