From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753243Ab0CQGEZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Mar 2010 02:04:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23246 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753174Ab0CQGEW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Mar 2010 02:04:22 -0400
Message-ID: <4BA071BD.5040900@redhat.com>
Date: Wed, 17 Mar 2010 14:07:57 +0800
From: Cong Wang <amwang@redhat.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20091001)
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [Patch] netpoll: allow spaces in its parameter
References: <20100317055707.5013.72217.sendpatchset@localhost.localdomain>	<20100316.225431.200776775.davem@davemloft.net>	<4BA07022.1040702@redhat.com> <20100316.225950.222623826.davem@davemloft.net>
In-Reply-To: <20100316.225950.222623826.davem@davemloft.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Wed, 17 Mar 2010 14:01:06 +0800
> 
>> The problem is that the dst port is 0 when I even use:
>>
>> "netconsole=@192.168.0.1/eth0, 66666@192.168.0.2/"
>>
>> This is awful too? I don't think so...
> 
> It's very simple, don't use spaces.  Is it so difficult
> to follow this rule?
> 

No, but silently accepting it as 0 is not correct, why don't
reject it if it is not allowed?