From: "H. Peter Anvin" <hpa@zytor.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: x86@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, alan@linux.intel.com,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/2]: serial8250: Use native_io_delay on the x86
Date: Wed, 17 Mar 2010 11:25:46 -0700 [thread overview]
Message-ID: <4BA11EAA.20506@zytor.com> (raw)
In-Reply-To: <20100317133050.54851ff8@marrow.netinsight.se>
On 03/17/2010 05:30 AM, Simon Kagstrom wrote:
> #ifdef __i386__
> - outb(0xff, 0x080);
> + native_io_delay();
> #endif
There is something a lot more weird about this. First of all, it's
#ifdef'd out on all but __i386__ including x86-64; second, it looks like
this is specific to synchronizing to the IER.
I'm wondering if the right thing isn't to add a dummy write to the SCR
register (or similar.)
-hpa
next prev parent reply other threads:[~2010-03-17 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 12:28 [PATCH 0/2]: x86: Honor IO_DELAY IO port settings Simon Kagstrom
2010-03-17 12:30 ` [PATCH 1/2]: serial8250: Use native_io_delay on the x86 Simon Kagstrom
2010-03-17 13:01 ` Alan Cox
2010-03-17 14:09 ` Simon Kagstrom
2010-03-17 18:25 ` H. Peter Anvin [this message]
2010-03-17 18:36 ` Alan Cox
2010-03-17 18:43 ` H. Peter Anvin
2010-03-17 12:30 ` [PATCH 2/2]: x86 real mode: Set delay port according to kernel config Simon Kagstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA11EAA.20506@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=simon.kagstrom@netinsight.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox