public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars Lindley <lindley@coyote.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: gregkh@suse.de, greg@kroah.com, pavel@ucw.cz,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: mds_f.h whitespace corrections.
Date: Thu, 18 Mar 2010 09:11:41 +0100	[thread overview]
Message-ID: <4BA1E03D.4050602@coyote.org> (raw)
In-Reply-To: <4BA1DE50.1080908@cs.helsinki.fi>

Sure..So Mds_SendComplete would be mds_send_complete?

/Lars

On 2010-03-18 09:03, Pekka Enberg wrote:
> Lars Lindley kirjoitti:
>> I fixed the whitespaces and the C99 comment.
>>
>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>> ---
>>  drivers/staging/winbond/mds_f.h |   20 ++++++++++----------
>>  1 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/winbond/mds_f.h
>> b/drivers/staging/winbond/mds_f.h
>> index e09dd4b..0d2bccf 100644
>> --- a/drivers/staging/winbond/mds_f.h
>> +++ b/drivers/staging/winbond/mds_f.h
>> @@ -4,17 +4,17 @@
>>  #include "wbhal_s.h"
>>  #include "core.h"
>>  
>> -unsigned char Mds_initial(  struct wbsoft_priv *adapter );
>> -void Mds_Destroy(  struct wbsoft_priv *adapter );
>> -void Mds_Tx(  struct wbsoft_priv *adapter );
>> -void Mds_SendComplete(  struct wbsoft_priv *adapter,  PT02_DESCRIPTOR
>> pT02 );
>> -void Mds_MpduProcess(  struct wbsoft_priv *adapter,  struct
>> wb35_descriptor *pRxDes );
>> +unsigned char Mds_initial(struct wbsoft_priv *adapter);
>> +void Mds_Destroy(struct wbsoft_priv *adapter);
>> +void Mds_Tx(struct wbsoft_priv *adapter);
>> +void Mds_SendComplete(struct wbsoft_priv *adapter, PT02_DESCRIPTOR
>> pT02);
>> +void Mds_MpduProcess(struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pRxDes);
>>  extern void DataDmp(u8 *pdata, u32 len, u32 offset);
>>  
>> -// For data frame sending 20060802
>> -u16 MDS_GetPacketSize(  struct wbsoft_priv *adapter );
>> -void MDS_GetNextPacket(  struct wbsoft_priv *adapter,  struct
>> wb35_descriptor *pDes );
>> -void MDS_GetNextPacketComplete(  struct wbsoft_priv *adapter,  struct
>> wb35_descriptor *pDes );
>> -void MDS_SendResult(  struct wbsoft_priv *adapter,  u8 PacketId, 
>> unsigned char SendOK );
>> +/* For data frame sending */
>> +u16 MDS_GetPacketSize(struct wbsoft_priv *adapter);
>> +void MDS_GetNextPacket(struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pDes);
>> +void MDS_GetNextPacketComplete(struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pDes);
>> +void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId,
>> unsigned char SendOK);
> 
> While you're at it, how about fixing up those CamelCase parameter names
> as well?
> 
>             Pekka
> 

  reply	other threads:[~2010-03-18  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  7:59 [PATCH] staging: winbond: mds_f.h whitespace corrections Lars Lindley
2010-03-18  8:03 ` Pekka Enberg
2010-03-18  8:11   ` Lars Lindley [this message]
2010-03-18  9:47     ` Pekka Enberg
2010-03-18  8:53   ` Lars Lindley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA1E03D.4050602@coyote.org \
    --to=lindley@coyote.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox