* [PATCH] staging: winbond: mds_f.h whitespace corrections.
@ 2010-03-18 7:59 Lars Lindley
2010-03-18 8:03 ` Pekka Enberg
0 siblings, 1 reply; 5+ messages in thread
From: Lars Lindley @ 2010-03-18 7:59 UTC (permalink / raw)
To: gregkh, greg, penberg, pavel; +Cc: devel, linux-kernel, Lars Lindley
I fixed the whitespaces and the C99 comment.
Signed-off-by: Lars Lindley <lindley@coyote.org>
---
drivers/staging/winbond/mds_f.h | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
index e09dd4b..0d2bccf 100644
--- a/drivers/staging/winbond/mds_f.h
+++ b/drivers/staging/winbond/mds_f.h
@@ -4,17 +4,17 @@
#include "wbhal_s.h"
#include "core.h"
-unsigned char Mds_initial( struct wbsoft_priv *adapter );
-void Mds_Destroy( struct wbsoft_priv *adapter );
-void Mds_Tx( struct wbsoft_priv *adapter );
-void Mds_SendComplete( struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02 );
-void Mds_MpduProcess( struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes );
+unsigned char Mds_initial(struct wbsoft_priv *adapter);
+void Mds_Destroy(struct wbsoft_priv *adapter);
+void Mds_Tx(struct wbsoft_priv *adapter);
+void Mds_SendComplete(struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02);
+void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes);
extern void DataDmp(u8 *pdata, u32 len, u32 offset);
-// For data frame sending 20060802
-u16 MDS_GetPacketSize( struct wbsoft_priv *adapter );
-void MDS_GetNextPacket( struct wbsoft_priv *adapter, struct wb35_descriptor *pDes );
-void MDS_GetNextPacketComplete( struct wbsoft_priv *adapter, struct wb35_descriptor *pDes );
-void MDS_SendResult( struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK );
+/* For data frame sending */
+u16 MDS_GetPacketSize(struct wbsoft_priv *adapter);
+void MDS_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
+void MDS_GetNextPacketComplete(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
+void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK);
#endif
--
1.7.0.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: winbond: mds_f.h whitespace corrections.
2010-03-18 7:59 [PATCH] staging: winbond: mds_f.h whitespace corrections Lars Lindley
@ 2010-03-18 8:03 ` Pekka Enberg
2010-03-18 8:11 ` Lars Lindley
2010-03-18 8:53 ` Lars Lindley
0 siblings, 2 replies; 5+ messages in thread
From: Pekka Enberg @ 2010-03-18 8:03 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, pavel, devel, linux-kernel
Lars Lindley kirjoitti:
> I fixed the whitespaces and the C99 comment.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
> ---
> drivers/staging/winbond/mds_f.h | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
> index e09dd4b..0d2bccf 100644
> --- a/drivers/staging/winbond/mds_f.h
> +++ b/drivers/staging/winbond/mds_f.h
> @@ -4,17 +4,17 @@
> #include "wbhal_s.h"
> #include "core.h"
>
> -unsigned char Mds_initial( struct wbsoft_priv *adapter );
> -void Mds_Destroy( struct wbsoft_priv *adapter );
> -void Mds_Tx( struct wbsoft_priv *adapter );
> -void Mds_SendComplete( struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02 );
> -void Mds_MpduProcess( struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes );
> +unsigned char Mds_initial(struct wbsoft_priv *adapter);
> +void Mds_Destroy(struct wbsoft_priv *adapter);
> +void Mds_Tx(struct wbsoft_priv *adapter);
> +void Mds_SendComplete(struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02);
> +void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes);
> extern void DataDmp(u8 *pdata, u32 len, u32 offset);
>
> -// For data frame sending 20060802
> -u16 MDS_GetPacketSize( struct wbsoft_priv *adapter );
> -void MDS_GetNextPacket( struct wbsoft_priv *adapter, struct wb35_descriptor *pDes );
> -void MDS_GetNextPacketComplete( struct wbsoft_priv *adapter, struct wb35_descriptor *pDes );
> -void MDS_SendResult( struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK );
> +/* For data frame sending */
> +u16 MDS_GetPacketSize(struct wbsoft_priv *adapter);
> +void MDS_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
> +void MDS_GetNextPacketComplete(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
> +void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK);
While you're at it, how about fixing up those CamelCase parameter names
as well?
Pekka
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: winbond: mds_f.h whitespace corrections.
2010-03-18 8:03 ` Pekka Enberg
@ 2010-03-18 8:11 ` Lars Lindley
2010-03-18 9:47 ` Pekka Enberg
2010-03-18 8:53 ` Lars Lindley
1 sibling, 1 reply; 5+ messages in thread
From: Lars Lindley @ 2010-03-18 8:11 UTC (permalink / raw)
To: Pekka Enberg; +Cc: gregkh, greg, pavel, devel, linux-kernel
Sure..So Mds_SendComplete would be mds_send_complete?
/Lars
On 2010-03-18 09:03, Pekka Enberg wrote:
> Lars Lindley kirjoitti:
>> I fixed the whitespaces and the C99 comment.
>>
>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>> ---
>> drivers/staging/winbond/mds_f.h | 20 ++++++++++----------
>> 1 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/winbond/mds_f.h
>> b/drivers/staging/winbond/mds_f.h
>> index e09dd4b..0d2bccf 100644
>> --- a/drivers/staging/winbond/mds_f.h
>> +++ b/drivers/staging/winbond/mds_f.h
>> @@ -4,17 +4,17 @@
>> #include "wbhal_s.h"
>> #include "core.h"
>>
>> -unsigned char Mds_initial( struct wbsoft_priv *adapter );
>> -void Mds_Destroy( struct wbsoft_priv *adapter );
>> -void Mds_Tx( struct wbsoft_priv *adapter );
>> -void Mds_SendComplete( struct wbsoft_priv *adapter, PT02_DESCRIPTOR
>> pT02 );
>> -void Mds_MpduProcess( struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pRxDes );
>> +unsigned char Mds_initial(struct wbsoft_priv *adapter);
>> +void Mds_Destroy(struct wbsoft_priv *adapter);
>> +void Mds_Tx(struct wbsoft_priv *adapter);
>> +void Mds_SendComplete(struct wbsoft_priv *adapter, PT02_DESCRIPTOR
>> pT02);
>> +void Mds_MpduProcess(struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pRxDes);
>> extern void DataDmp(u8 *pdata, u32 len, u32 offset);
>>
>> -// For data frame sending 20060802
>> -u16 MDS_GetPacketSize( struct wbsoft_priv *adapter );
>> -void MDS_GetNextPacket( struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pDes );
>> -void MDS_GetNextPacketComplete( struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pDes );
>> -void MDS_SendResult( struct wbsoft_priv *adapter, u8 PacketId,
>> unsigned char SendOK );
>> +/* For data frame sending */
>> +u16 MDS_GetPacketSize(struct wbsoft_priv *adapter);
>> +void MDS_GetNextPacket(struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pDes);
>> +void MDS_GetNextPacketComplete(struct wbsoft_priv *adapter, struct
>> wb35_descriptor *pDes);
>> +void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId,
>> unsigned char SendOK);
>
> While you're at it, how about fixing up those CamelCase parameter names
> as well?
>
> Pekka
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: winbond: mds_f.h whitespace corrections.
2010-03-18 8:03 ` Pekka Enberg
2010-03-18 8:11 ` Lars Lindley
@ 2010-03-18 8:53 ` Lars Lindley
1 sibling, 0 replies; 5+ messages in thread
From: Lars Lindley @ 2010-03-18 8:53 UTC (permalink / raw)
To: Pekka Enberg; +Cc: gregkh, greg, pavel, devel, linux-kernel
OK, new patch coming soon..
I misread your reply first and thought you meant function names..That's a
bit more work better done after the code is more readable in the whole
winbond driver.. :)
/Lars
On 2010-03-18 09:03, Pekka Enberg wrote:
> Lars Lindley kirjoitti:
>> +void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId,
>> unsigned char SendOK);
>
> While you're at it, how about fixing up those CamelCase parameter names
> as well?
>
> Pekka
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-03-18 9:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-18 7:59 [PATCH] staging: winbond: mds_f.h whitespace corrections Lars Lindley
2010-03-18 8:03 ` Pekka Enberg
2010-03-18 8:11 ` Lars Lindley
2010-03-18 9:47 ` Pekka Enberg
2010-03-18 8:53 ` Lars Lindley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox