* [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
@ 2010-03-18 15:57 Lars Lindley
2010-03-18 16:28 ` Pekka Enberg
0 siblings, 1 reply; 6+ messages in thread
From: Lars Lindley @ 2010-03-18 15:57 UTC (permalink / raw)
To: gregkh, greg, penberg, pavel; +Cc: devel, linux-kernel, Lars Lindley
I fixed all problems found by checkpatch.pl and removed CamelCase
from argument names.
Signed-off-by: Lars Lindley <lindley@coyote.org>
---
drivers/staging/winbond/mlmetxrx_f.h | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/winbond/mlmetxrx_f.h b/drivers/staging/winbond/mlmetxrx_f.h
index 6c04e3e..02dfd46 100644
--- a/drivers/staging/winbond/mlmetxrx_f.h
+++ b/drivers/staging/winbond/mlmetxrx_f.h
@@ -1,25 +1,26 @@
-//================================================================
-// MLMETxRx.H --
-//
-// Functions defined in MLMETxRx.c.
-//
-// Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
-//================================================================
+/* ================================================================
+ * MLMETxRx.H --
+ *
+ * Functions defined in MLMETxRx.c.
+ *
+ * Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
+ * ================================================================
+ */
#ifndef _MLMETXRX_H
#define _MLMETXRX_H
#include "core.h"
-void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
+void MLME_GetNextPacket(struct wbsoft_priv *adapter,
+ struct wb35_descriptor *pdes);
u8 MLMESendFrame(struct wbsoft_priv *adapter,
- u8 * pMMPDU, u16 len, u8 DataType);
+ u8 *pmmpdu, u16 len, u8 datatype);
-void
-MLME_SendComplete(struct wbsoft_priv *adapter, u8 PacketID,
- unsigned char SendOK);
+void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid,
+ unsigned char sendok);
#ifdef _IBSS_BEACON_SEQ_STICK_
-s8 SendBCNullData(struct wbsoft_priv *adapter, u16 wIdx);
+s8 SendBCNullData(struct wbsoft_priv *adapter, u16 widx);
#endif
#endif
--
1.7.0.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
2010-03-18 15:57 [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes Lars Lindley
@ 2010-03-18 16:28 ` Pekka Enberg
2010-03-18 22:17 ` Lars Lindley
0 siblings, 1 reply; 6+ messages in thread
From: Pekka Enberg @ 2010-03-18 16:28 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, pavel, devel, linux-kernel
Lars Lindley wrote:
> I fixed all problems found by checkpatch.pl and removed CamelCase
> from argument names.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
> ---
> drivers/staging/winbond/mlmetxrx_f.h | 27 ++++++++++++++-------------
> 1 files changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/winbond/mlmetxrx_f.h b/drivers/staging/winbond/mlmetxrx_f.h
> index 6c04e3e..02dfd46 100644
> --- a/drivers/staging/winbond/mlmetxrx_f.h
> +++ b/drivers/staging/winbond/mlmetxrx_f.h
> @@ -1,25 +1,26 @@
> -//================================================================
> -// MLMETxRx.H --
> -//
> -// Functions defined in MLMETxRx.c.
> -//
> -// Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
> -//================================================================
> +/* ================================================================
> + * MLMETxRx.H --
> + *
> + * Functions defined in MLMETxRx.c.
> + *
> + * Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
> + * ================================================================
> + */
> #ifndef _MLMETXRX_H
> #define _MLMETXRX_H
>
> #include "core.h"
>
> -void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
> + struct wb35_descriptor *pdes);
Can we get rid of the "p" prefix (hungarian notation) while at it?
> u8 MLMESendFrame(struct wbsoft_priv *adapter,
> - u8 * pMMPDU, u16 len, u8 DataType);
> + u8 *pmmpdu, u16 len, u8 datatype);
>
> -void
> -MLME_SendComplete(struct wbsoft_priv *adapter, u8 PacketID,
> - unsigned char SendOK);
> +void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid,
> + unsigned char sendok);
>
> #ifdef _IBSS_BEACON_SEQ_STICK_
> -s8 SendBCNullData(struct wbsoft_priv *adapter, u16 wIdx);
> +s8 SendBCNullData(struct wbsoft_priv *adapter, u16 widx);
> #endif
>
> #endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
2010-03-18 16:28 ` Pekka Enberg
@ 2010-03-18 22:17 ` Lars Lindley
2010-03-19 5:44 ` Pekka Enberg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lars Lindley @ 2010-03-18 22:17 UTC (permalink / raw)
To: Pekka Enberg; +Cc: gregkh, greg, pavel, devel, linux-kernel
On 2010-03-18 17:28, Pekka Enberg wrote:
> Lars Lindley wrote:
>> I fixed all problems found by checkpatch.pl and removed CamelCase
>> from argument names.
..snip..
>> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
>> + struct wb35_descriptor *pdes);
>
> Can we get rid of the "p" prefix (hungarian notation) while at it?
>
Sure..
I changed pdes to des, pmmpdu to mmpdu and widx to idx.
Looks all right?
/Lars
Here is the new patch against master:
[PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
I fixed all problems found by checkpatch.pl and removed CamelCase
and hungarian notation from the argument names.
Signed-off-by: Lars Lindley <lindley@coyote.org>
---
drivers/staging/winbond/mlmetxrx_f.h | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/winbond/mlmetxrx_f.h b/drivers/staging/winbond/mlmetxrx_f.h
index 6c04e3e..2bfa2e3 100644
--- a/drivers/staging/winbond/mlmetxrx_f.h
+++ b/drivers/staging/winbond/mlmetxrx_f.h
@@ -1,25 +1,26 @@
-//================================================================
-// MLMETxRx.H --
-//
-// Functions defined in MLMETxRx.c.
-//
-// Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
-//================================================================
+/* ================================================================
+ * MLMETxRx.H --
+ *
+ * Functions defined in MLMETxRx.c.
+ *
+ * Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
+ * ================================================================
+ */
#ifndef _MLMETXRX_H
#define _MLMETXRX_H
#include "core.h"
-void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
+void MLME_GetNextPacket(struct wbsoft_priv *adapter,
+ struct wb35_descriptor *des);
u8 MLMESendFrame(struct wbsoft_priv *adapter,
- u8 * pMMPDU, u16 len, u8 DataType);
+ u8 *mmpdu, u16 len, u8 datatype);
-void
-MLME_SendComplete(struct wbsoft_priv *adapter, u8 PacketID,
- unsigned char SendOK);
+void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid,
+ unsigned char sendok);
#ifdef _IBSS_BEACON_SEQ_STICK_
-s8 SendBCNullData(struct wbsoft_priv *adapter, u16 wIdx);
+s8 SendBCNullData(struct wbsoft_priv *adapter, u16 idx);
#endif
#endif
--
1.7.0.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
2010-03-18 22:17 ` Lars Lindley
@ 2010-03-19 5:44 ` Pekka Enberg
2010-03-21 7:00 ` Pavel Machek
2010-04-28 22:56 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Pekka Enberg @ 2010-03-19 5:44 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, pavel, devel, linux-kernel
Lars Lindley wrote:
> On 2010-03-18 17:28, Pekka Enberg wrote:
>> Lars Lindley wrote:
>>> I fixed all problems found by checkpatch.pl and removed CamelCase
>>> from argument names.
> ..snip..
>>> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
>>> + struct wb35_descriptor *pdes);
>> Can we get rid of the "p" prefix (hungarian notation) while at it?
>>
> Sure..
> I changed pdes to des, pmmpdu to mmpdu and widx to idx.
> Looks all right?
>
> /Lars
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
2010-03-18 22:17 ` Lars Lindley
2010-03-19 5:44 ` Pekka Enberg
@ 2010-03-21 7:00 ` Pavel Machek
2010-04-28 22:56 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2010-03-21 7:00 UTC (permalink / raw)
To: Lars Lindley; +Cc: Pekka Enberg, gregkh, greg, devel, linux-kernel
On Thu 2010-03-18 23:17:49, Lars Lindley wrote:
> On 2010-03-18 17:28, Pekka Enberg wrote:
> > Lars Lindley wrote:
> >> I fixed all problems found by checkpatch.pl and removed CamelCase
> >> from argument names.
> ..snip..
> >> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
> >> + struct wb35_descriptor *pdes);
> >
> > Can we get rid of the "p" prefix (hungarian notation) while at it?
> >
> Sure..
> I changed pdes to des, pmmpdu to mmpdu and widx to idx.
> Looks all right?
>
> /Lars
>
>
>
> Here is the new patch against master:
>
> [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
>
> I fixed all problems found by checkpatch.pl and removed CamelCase
> and hungarian notation from the argument names.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
2010-03-18 22:17 ` Lars Lindley
2010-03-19 5:44 ` Pekka Enberg
2010-03-21 7:00 ` Pavel Machek
@ 2010-04-28 22:56 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2010-04-28 22:56 UTC (permalink / raw)
To: Lars Lindley; +Cc: Pekka Enberg, gregkh, pavel, devel, linux-kernel
On Thu, Mar 18, 2010 at 11:17:49PM +0100, Lars Lindley wrote:
> On 2010-03-18 17:28, Pekka Enberg wrote:
> > Lars Lindley wrote:
> >> I fixed all problems found by checkpatch.pl and removed CamelCase
> >> from argument names.
> ..snip..
> >> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
> >> + struct wb35_descriptor *pdes);
> >
> > Can we get rid of the "p" prefix (hungarian notation) while at it?
> >
> Sure..
> I changed pdes to des, pmmpdu to mmpdu and widx to idx.
> Looks all right?
>
> /Lars
>
>
>
> Here is the new patch against master:
>
> [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
>
> I fixed all problems found by checkpatch.pl and removed CamelCase
> and hungarian notation from the argument names.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
This one didn't apply for some reason :(
Care to redo it against linux-next tomorrow?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-28 23:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-18 15:57 [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes Lars Lindley
2010-03-18 16:28 ` Pekka Enberg
2010-03-18 22:17 ` Lars Lindley
2010-03-19 5:44 ` Pekka Enberg
2010-03-21 7:00 ` Pavel Machek
2010-04-28 22:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox