* latent problem in free_init_pages()
@ 2010-03-19 10:25 Jan Beulich
2010-03-19 14:02 ` Arjan van de Ven
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2010-03-19 10:25 UTC (permalink / raw)
To: Ingo Molnar, arjan; +Cc: linux-kernel
The calls to set_memory_rw() and set_memory_np() that both of you
added for 2.6.25 imply that both "begin" and "end" are page aligned.
This isn't the case, however, for the initrd and SMP locks. While at
present this doesn't appear to do any harm, it partly subverts the
debugging effect of the latter change and would result in a real issue
if the .smp_locks section was moved into the read-only portion of the
kernel image (where it really belongs imo).
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: latent problem in free_init_pages()
2010-03-19 10:25 latent problem in free_init_pages() Jan Beulich
@ 2010-03-19 14:02 ` Arjan van de Ven
0 siblings, 0 replies; 2+ messages in thread
From: Arjan van de Ven @ 2010-03-19 14:02 UTC (permalink / raw)
To: Jan Beulich; +Cc: Ingo Molnar, linux-kernel
On 3/19/2010 3:25, Jan Beulich wrote:
> The calls to set_memory_rw() and set_memory_np() that both of you
> added for 2.6.25 imply that both "begin" and "end" are page aligned.
> This isn't the case, however, for the initrd and SMP locks. While at
> present this doesn't appear to do any harm, it partly subverts the
> debugging effect of the latter change and would result in a real issue
> if the .smp_locks section was moved into the read-only portion of the
> kernel image (where it really belongs imo).
if you change the linker script to move the section, you should also move it to
keep the end page aligned.
solving that at link time (like is done now) is obviously nicer than solving it at runtime ;-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-19 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-19 10:25 latent problem in free_init_pages() Jan Beulich
2010-03-19 14:02 ` Arjan van de Ven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox