public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* PATCH:  Fix snd-hda-intel boot hang on ASUS A8N-VM
@ 2010-03-16 23:17 Brian Lindholm
  2010-03-17  7:16 ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Brian Lindholm @ 2010-03-16 23:17 UTC (permalink / raw)
  To: perex, tiwai, alsa-devel; +Cc: linux-kernel

This patch fixes a regression in 2.6.33.x.  Was working in 2.6.32.x.

   Symptom:  Hang on boot at "HDA Intel".  Boots only if on-board sound 
is disabled or if "snd-hda-intel.enable_msi=0" is appended to boot 
parameters.

   Machine:  ASUS A8N-VM with Athlon-X2 processor.

   Relevant output from lspci -nn:

00:10.1 Audio device [0403]: nVidia Corporation MCP51 High Definition 
Audio [10de:026c] (rev a2)

   Relevant output from alsa-info.sh:

00:10.1 Audio device: nVidia Corporation MCP51 High Definition Audio 
(rev a2)
00:10.1 0403: 10de:026c (rev a2)
         Subsystem: 10de:cb84

   Proposed patch (which has been confirmed to allow boot, with sound 
active):

diff -dru linux-2.6.33-orig/sound/pci/hda/hda_intel.c 
linux-2.6.33/sound/pci/hda/hda_intel.c
--- linux-2.6.33-orig/sound/pci/hda/hda_intel.c        2010-03-16 
17:33:23.487938000 -0400
+++ linux-2.6.33/sound/pci/hda/hda_intel.c      2010-03-16 
17:40:36.141225010 -0400
@@ -2354,6 +2354,7 @@ static void __devinit check_probe_mask(s
  static struct snd_pci_quirk msi_black_list[] __devinitdata = {
         SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + 
nvidia */
         SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
+       SND_PCI_QUIRK(0x10de, 0xcb84, "ASUS", 0), /* nvidia */
         {}
  };

Signed-off-by: Brian E Lindholm <brian_lindholm@users.sourceforge.net>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH:  Fix snd-hda-intel boot hang on ASUS A8N-VM
  2010-03-16 23:17 PATCH: Fix snd-hda-intel boot hang on ASUS A8N-VM Brian Lindholm
@ 2010-03-17  7:16 ` Takashi Iwai
  2010-03-19 19:26   ` Michael Tokarev
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2010-03-17  7:16 UTC (permalink / raw)
  To: Brian Lindholm; +Cc: perex, alsa-devel, linux-kernel

At Tue, 16 Mar 2010 19:17:52 -0400,
Brian Lindholm wrote:
> 
> This patch fixes a regression in 2.6.33.x.  Was working in 2.6.32.x.
> 
>    Symptom:  Hang on boot at "HDA Intel".  Boots only if on-board sound 
> is disabled or if "snd-hda-intel.enable_msi=0" is appended to boot 
> parameters.
> 
>    Machine:  ASUS A8N-VM with Athlon-X2 processor.
> 
>    Relevant output from lspci -nn:
> 
> 00:10.1 Audio device [0403]: nVidia Corporation MCP51 High Definition 
> Audio [10de:026c] (rev a2)
> 
>    Relevant output from alsa-info.sh:
> 
> 00:10.1 Audio device: nVidia Corporation MCP51 High Definition Audio 
> (rev a2)
> 00:10.1 0403: 10de:026c (rev a2)
>          Subsystem: 10de:cb84
> 
>    Proposed patch (which has been confirmed to allow boot, with sound 
> active):

Thanks for the patch.  The issue was already fixed in a different way,
namely, disable MSI for all Nvidia controller chips.  The fix will be
included in the next pull request and stable kernel.


Takashi

> diff -dru linux-2.6.33-orig/sound/pci/hda/hda_intel.c 
> linux-2.6.33/sound/pci/hda/hda_intel.c
> --- linux-2.6.33-orig/sound/pci/hda/hda_intel.c        2010-03-16 
> 17:33:23.487938000 -0400
> +++ linux-2.6.33/sound/pci/hda/hda_intel.c      2010-03-16 
> 17:40:36.141225010 -0400
> @@ -2354,6 +2354,7 @@ static void __devinit check_probe_mask(s
>   static struct snd_pci_quirk msi_black_list[] __devinitdata = {
>          SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + 
> nvidia */
>          SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
> +       SND_PCI_QUIRK(0x10de, 0xcb84, "ASUS", 0), /* nvidia */
>          {}
>   };
> 
> Signed-off-by: Brian E Lindholm <brian_lindholm@users.sourceforge.net>
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH: Fix snd-hda-intel boot hang on ASUS A8N-VM
  2010-03-17  7:16 ` Takashi Iwai
@ 2010-03-19 19:26   ` Michael Tokarev
  2010-03-21  8:29     ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2010-03-19 19:26 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Brian Lindholm, perex, alsa-devel, linux-kernel

Takashi Iwai wrote:
> At Tue, 16 Mar 2010 19:17:52 -0400,
> Brian Lindholm wrote:
>> This patch fixes a regression in 2.6.33.x.  Was working in 2.6.32.x.
>>
>>    Symptom:  Hang on boot at "HDA Intel".  Boots only if on-board sound 
>> is disabled or if "snd-hda-intel.enable_msi=0" is appended to boot 
>> parameters.
>>
>>    Machine:  ASUS A8N-VM with Athlon-X2 processor.
[]
> Thanks for the patch.  The issue was already fixed in a different way,
> namely, disable MSI for all Nvidia controller chips.  The fix will be
> included in the next pull request and stable kernel.

Can you provide a bit more information?  I've the same issue at
hand, on an Acer Aspire 9300 notebook, also with nvidia chipset.
So far I disabled snd-hda-intel module loading, but it'd be nice
to actually have sound working on this machine, as well as to
test the patch... ;)

Thanks!

/mjt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH: Fix snd-hda-intel boot hang on ASUS A8N-VM
  2010-03-19 19:26   ` Michael Tokarev
@ 2010-03-21  8:29     ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2010-03-21  8:29 UTC (permalink / raw)
  To: Michael Tokarev; +Cc: Brian Lindholm, perex, alsa-devel, linux-kernel

At Fri, 19 Mar 2010 22:26:35 +0300,
Michael Tokarev wrote:
> 
> Takashi Iwai wrote:
> > At Tue, 16 Mar 2010 19:17:52 -0400,
> > Brian Lindholm wrote:
> >> This patch fixes a regression in 2.6.33.x.  Was working in 2.6.32.x.
> >>
> >>    Symptom:  Hang on boot at "HDA Intel".  Boots only if on-board sound 
> >> is disabled or if "snd-hda-intel.enable_msi=0" is appended to boot 
> >> parameters.
> >>
> >>    Machine:  ASUS A8N-VM with Athlon-X2 processor.
> []
> > Thanks for the patch.  The issue was already fixed in a different way,
> > namely, disable MSI for all Nvidia controller chips.  The fix will be
> > included in the next pull request and stable kernel.
> 
> Can you provide a bit more information?  I've the same issue at
> hand, on an Acer Aspire 9300 notebook, also with nvidia chipset.
> So far I disabled snd-hda-intel module loading, but it'd be nice
> to actually have sound working on this machine, as well as to
> test the patch... ;)

Take a look at:

commit 80c43ed724797627d8f86855248c497a6161a214
Author: Takashi Iwai <tiwai@suse.de>
Date:   Mon Mar 15 15:51:53 2010 +0100

    ALSA: hda - Disable MSI for Nvidia controller

It's marked to Cc to stable, so the patch will be applied later
to 2.6.33.x kernel, too.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-03-21  8:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 23:17 PATCH: Fix snd-hda-intel boot hang on ASUS A8N-VM Brian Lindholm
2010-03-17  7:16 ` Takashi Iwai
2010-03-19 19:26   ` Michael Tokarev
2010-03-21  8:29     ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox