From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Ian Campbell <ian.campbell@citrix.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: do not free zero sized per cpu areas
Date: Fri, 19 Mar 2010 14:42:06 -0700 [thread overview]
Message-ID: <4BA3EFAE.9070004@zytor.com> (raw)
In-Reply-To: <4BA3CF67.9000107@kernel.org>
On 03/19/2010 12:24 PM, Yinghai Lu wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
>
> This avoids an infinite loop in free_early_partial().
>
> Add a warning to free_early_partial to catch future problems.
Wouldn't it make more sense to simply make free_early_partial() a noop
for the zero range, instead of pushing all those tests into the callers?
It still might make sense to have a WARN_ONCE() for a *negative* range,
however...
-hpa
next prev parent reply other threads:[~2010-03-19 21:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 15:03 Infinite loop on boot in free_early_partial due to start==end on tip/master Ian Campbell
2010-03-05 18:16 ` Yinghai Lu
2010-03-05 19:45 ` Ian Campbell
2010-03-05 19:49 ` [PATCH] x86: do not free zero sized per cpu areas Ian Campbell
2010-03-05 19:51 ` Yinghai Lu
2010-03-19 19:24 ` Yinghai Lu
2010-03-19 21:42 ` H. Peter Anvin [this message]
2010-03-19 22:18 ` [PATCH -v3] " Yinghai Lu
2010-03-19 22:21 ` H. Peter Anvin
2010-03-19 23:24 ` Yinghai Lu
2010-03-19 23:29 ` H. Peter Anvin
2010-03-19 23:45 ` [PATCH -v4] " Yinghai Lu
2010-03-20 1:00 ` Linus Torvalds
2010-03-20 1:59 ` [PATCH -v5] " Yinghai Lu
2010-03-20 2:41 ` Linus Torvalds
2010-03-20 6:38 ` [PATCH -v6] " Yinghai Lu
2010-03-20 7:12 ` Ian Campbell
2010-03-22 17:30 ` [LKML] " Konrad Rzeszutek Wilk
2010-03-19 23:35 ` [PATCH -v3] " Ian Campbell
2010-03-19 23:43 ` Ian Campbell
2010-03-19 23:43 ` H. Peter Anvin
2010-03-19 18:28 ` Infinite loop on boot in free_early_partial due to start==end on tip/master Konrad Rzeszutek Wilk
2010-03-19 19:04 ` Yinghai Lu
2010-03-19 19:34 ` Ian Campbell
2010-03-19 20:04 ` [LKML] " Konrad Rzeszutek Wilk
2010-03-19 21:17 ` Yinghai Lu
2010-03-19 21:37 ` Ian Campbell
2010-03-20 3:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA3EFAE.9070004@zytor.com \
--to=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox