From: "H. Peter Anvin" <hpa@zytor.com>
To: "René Bolldorf" <xsecute@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31)
Date: Fri, 19 Mar 2010 14:45:44 -0700 [thread overview]
Message-ID: <4BA3F088.8040203@zytor.com> (raw)
In-Reply-To: <4BA2A45B.6060004@googlemail.com>
On 03/18/2010 03:08 PM, René Bolldorf wrote:
> Signed-off-by: Rene Bolldorf <xsecute@googlemail.com>
>
> diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
> index 37c3d4b..8bfba5e 100644
> --- a/arch/x86/kernel/head_32.S
> +++ b/arch/x86/kernel/head_32.S
> @@ -62,7 +62,7 @@
>
> /* Enough space to fit pagetables for the low memory linear map */
> MAPPING_BEYOND_END = \
> - PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
> + PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
>
> /*
> * Worst-case size of the kernel mapping we need to make:
NAK... this is in fact doubly wrong... the assembler handles this case
just fine -- it's a .S file after all -- and the result is wrong.
If you want to change it change it to 0x100000000.
-hpa
next prev parent reply other threads:[~2010-03-19 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 22:08 [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31) René Bolldorf
2010-03-19 21:45 ` H. Peter Anvin [this message]
2010-03-19 22:43 ` René Bolldorf
2010-03-19 23:27 ` René Bolldorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA3F088.8040203@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xsecute@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox