From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060Ab0CSWnv (ORCPT ); Fri, 19 Mar 2010 18:43:51 -0400 Received: from mail-fx0-f219.google.com ([209.85.220.219]:54424 "EHLO mail-fx0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695Ab0CSWnt (ORCPT ); Fri, 19 Mar 2010 18:43:49 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=VM8hWheQEzPJLqKpFmQ78vHU0Xn2bXvJaxacfUknqNSkuB7dDPE+qIXlym3OezJ6Gg UA8GARcSejCtx/FWOUoU05nER62X0mcV8eygXVLZoJ7ybLcB9dGFToY/ZIEmsjmSdOBq R96kC2R4hNe7bhyXUrOkSRLffB8rdkOg9qfQs= Message-ID: <4BA3FE2D.6070301@googlemail.com> Date: Fri, 19 Mar 2010 23:43:57 +0100 From: =?UTF-8?B?UmVuw6kgQm9sbGRvcmY=?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: "H. Peter Anvin" CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31) References: <4BA2A45B.6060004@googlemail.com> <4BA3F088.8040203@zytor.com> In-Reply-To: <4BA3F088.8040203@zytor.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/19/10 22:45, H. Peter Anvin wrote: > On 03/18/2010 03:08 PM, Ren� Bolldorf wrote: >> Signed-off-by: Rene Bolldorf >> >> diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S >> index 37c3d4b..8bfba5e 100644 >> --- a/arch/x86/kernel/head_32.S >> +++ b/arch/x86/kernel/head_32.S >> @@ -62,7 +62,7 @@ >> >> /* Enough space to fit pagetables for the low memory linear map */ >> MAPPING_BEYOND_END = \ >> - PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET)>> PAGE_SHIFT)<< PAGE_SHIFT >> + PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET)>> PAGE_SHIFT)<< PAGE_SHIFT >> >> /* >> * Worst-case size of the kernel mapping we need to make: > > NAK... this is in fact doubly wrong... the assembler handles this case > just fine -- it's a .S file after all -- and the result is wrong. > > If you want to change it change it to 0x100000000. > > -hpa Thank you, i try it out.