* [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31)
@ 2010-03-18 22:08 René Bolldorf
2010-03-19 21:45 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: René Bolldorf @ 2010-03-18 22:08 UTC (permalink / raw)
To: linux-kernel
Signed-off-by: Rene Bolldorf <xsecute@googlemail.com>
diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index 37c3d4b..8bfba5e 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -62,7 +62,7 @@
/* Enough space to fit pagetables for the low memory linear map */
MAPPING_BEYOND_END = \
- PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
+ PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
/*
* Worst-case size of the kernel mapping we need to make:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31)
2010-03-18 22:08 [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31) René Bolldorf
@ 2010-03-19 21:45 ` H. Peter Anvin
2010-03-19 22:43 ` René Bolldorf
2010-03-19 23:27 ` René Bolldorf
0 siblings, 2 replies; 4+ messages in thread
From: H. Peter Anvin @ 2010-03-19 21:45 UTC (permalink / raw)
To: René Bolldorf; +Cc: linux-kernel
On 03/18/2010 03:08 PM, René Bolldorf wrote:
> Signed-off-by: Rene Bolldorf <xsecute@googlemail.com>
>
> diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
> index 37c3d4b..8bfba5e 100644
> --- a/arch/x86/kernel/head_32.S
> +++ b/arch/x86/kernel/head_32.S
> @@ -62,7 +62,7 @@
>
> /* Enough space to fit pagetables for the low memory linear map */
> MAPPING_BEYOND_END = \
> - PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
> + PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
>
> /*
> * Worst-case size of the kernel mapping we need to make:
NAK... this is in fact doubly wrong... the assembler handles this case
just fine -- it's a .S file after all -- and the result is wrong.
If you want to change it change it to 0x100000000.
-hpa
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31)
2010-03-19 21:45 ` H. Peter Anvin
@ 2010-03-19 22:43 ` René Bolldorf
2010-03-19 23:27 ` René Bolldorf
1 sibling, 0 replies; 4+ messages in thread
From: René Bolldorf @ 2010-03-19 22:43 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: linux-kernel
On 03/19/10 22:45, H. Peter Anvin wrote:
> On 03/18/2010 03:08 PM, Ren� Bolldorf wrote:
>> Signed-off-by: Rene Bolldorf<xsecute@googlemail.com>
>>
>> diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
>> index 37c3d4b..8bfba5e 100644
>> --- a/arch/x86/kernel/head_32.S
>> +++ b/arch/x86/kernel/head_32.S
>> @@ -62,7 +62,7 @@
>>
>> /* Enough space to fit pagetables for the low memory linear map */
>> MAPPING_BEYOND_END = \
>> - PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET)>> PAGE_SHIFT)<< PAGE_SHIFT
>> + PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET)>> PAGE_SHIFT)<< PAGE_SHIFT
>>
>> /*
>> * Worst-case size of the kernel mapping we need to make:
>
> NAK... this is in fact doubly wrong... the assembler handles this case
> just fine -- it's a .S file after all -- and the result is wrong.
>
> If you want to change it change it to 0x100000000.
>
> -hpa
Thank you, i try it out.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31)
2010-03-19 21:45 ` H. Peter Anvin
2010-03-19 22:43 ` René Bolldorf
@ 2010-03-19 23:27 ` René Bolldorf
1 sibling, 0 replies; 4+ messages in thread
From: René Bolldorf @ 2010-03-19 23:27 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: linux-kernel
On 03/19/10 22:45, H. Peter Anvin wrote:
> On 03/18/2010 03:08 PM, Ren� Bolldorf wrote:
>> Signed-off-by: Rene Bolldorf<xsecute@googlemail.com>
>>
>> diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
>> index 37c3d4b..8bfba5e 100644
>> --- a/arch/x86/kernel/head_32.S
>> +++ b/arch/x86/kernel/head_32.S
>> @@ -62,7 +62,7 @@
>>
>> /* Enough space to fit pagetables for the low memory linear map */
>> MAPPING_BEYOND_END = \
>> - PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET)>> PAGE_SHIFT)<< PAGE_SHIFT
>> + PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET)>> PAGE_SHIFT)<< PAGE_SHIFT
>>
>> /*
>> * Worst-case size of the kernel mapping we need to make:
>
> NAK... this is in fact doubly wrong... the assembler handles this case
> just fine -- it's a .S file after all -- and the result is wrong.
>
> If you want to change it change it to 0x100000000.
>
> -hpa
The funny thing is even if i change to 0x100000000 or 0 etc., the
compiler warns me. Is this normal or a compiler issue?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-19 23:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-18 22:08 [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31) René Bolldorf
2010-03-19 21:45 ` H. Peter Anvin
2010-03-19 22:43 ` René Bolldorf
2010-03-19 23:27 ` René Bolldorf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox