From: Avi Kivity <avi@redhat.com>
To: Dmitry Torokhov <dtor@vmware.com>
Cc: linux-kernel@vger.kernel.org, pv-drivers@vmware.com,
Alok Kataria <akataria@vmware.com>,
Saileshkumar Jain <sajain@vmware.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 4/4] Add VMware memory balloon driver
Date: Sat, 20 Mar 2010 15:10:57 +0200 [thread overview]
Message-ID: <4BA4C961.9060006@redhat.com> (raw)
In-Reply-To: <20100319204702.4418.92437.stgit@localhost.localdomain>
On 03/19/2010 10:47 PM, Dmitry Torokhov wrote:
> This is a virtio-based transport between VMware's hypervisor
> and virtio_ballon driver that allows host control guest memory
> ballooning.
>
>
This is a little wierd since it's specific to the balloon driver. The
virtio design is to make transport and device orthogonal so we could
mix'n'match any driver with any transport, but this will only work with
the balloon driver. It's also 640 lines while the original balloon
driver is ~300. Some of that is because you're emulating a queue that
doesn't really exist, IIUC.
So while I'd love to see other hypervisors adopt virtio, I think in this
case it makes more sense to have your own balloon driver.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-03-20 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 20:46 [RFC/PATCH 0/4] VMware balloon driver over virtio Dmitry Torokhov
2010-03-19 20:46 ` [PATCH 1/4] virtio-balloon: allow hypervisor refuse locking some pages Dmitry Torokhov
2010-03-20 13:01 ` Avi Kivity
2010-03-19 20:46 ` [PATCH 2/4] virtio-balloon: implement balloon reset Dmitry Torokhov
2010-03-19 20:46 ` [PATCH 3/4] x86: export vmware_platform() symbol Dmitry Torokhov
2010-03-19 20:47 ` [PATCH 4/4] Add VMware memory balloon driver Dmitry Torokhov
2010-03-20 13:10 ` Avi Kivity [this message]
2010-03-20 19:54 ` Dmitry Torokhov
2010-03-21 9:19 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA4C961.9060006@redhat.com \
--to=avi@redhat.com \
--cc=akataria@vmware.com \
--cc=dtor@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rusty@rustcorp.com.au \
--cc=sajain@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox