From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753206Ab0CTPs3 (ORCPT ); Sat, 20 Mar 2010 11:48:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12811 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515Ab0CTPs2 (ORCPT ); Sat, 20 Mar 2010 11:48:28 -0400 Message-ID: <4BA4EEAE.10202@redhat.com> Date: Sat, 20 Mar 2010 11:50:06 -0400 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc11 Thunderbird/3.0.1 MIME-Version: 1.0 To: Srikar Dronamraju CC: Peter Zijlstra , Ingo Molnar , Andrew Morton , Linus Torvalds , Mel Gorman , Ananth N Mavinakayanahalli , Jim Keniston , Frederic Weisbecker , "Frank Ch. Eigler" , LKML Subject: Re: [PATCH v1 1/10] Move Macro W to insn.h References: <20100320142455.11427.76925.sendpatchset@localhost6.localdomain6> <20100320142505.11427.30133.sendpatchset@localhost6.localdomain6> In-Reply-To: <20100320142505.11427.30133.sendpatchset@localhost6.localdomain6> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Srikar Dronamraju wrote: > Move Macro W to asm/insn.h > > Macro W used to know if the instructions are valid for > user-space/kernel space. This macro is used by kprobes and > user_bkpt. (i.e user space breakpoint assistance layer.) So moving it > to a common header file asm/insn.h. Hmm, I don't think this shortest macro name is good to expose commonly... And also, since we already have inat (instruction attribute) table, we'd better expand an inat bit to indicate which instruction can be probed/boosted. Thank you, -- Masami Hiramatsu e-mail: mhiramat@redhat.com