From: "H. Peter Anvin" <hpa@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] x86-32: Split cache flush handler from simd handler
Date: Sat, 20 Mar 2010 11:53:23 -0700 [thread overview]
Message-ID: <4BA519A3.3000605@kernel.org> (raw)
In-Reply-To: <4BA45527.5050202@zytor.com>
On 03/19/2010 09:55 PM, H. Peter Anvin wrote:
>
> Ah, guess it was even older than I first realized ... I should have
> searched for the string "cache flush denied" instead.
>
> Sounds like we should do three things:
>
> a) update the comment to actually reflect what is going on;
> b) compile it out for > 486;
> c) report the error as trap 13 rather than 19.
>
Actually what we should do is recognize that this is nothing other than
a misdirected #GP, and as a result send the fault down the #GP handler
(do_general_protection)... there really isn't any need for a special
routine at all.
-hpa
next prev parent reply other threads:[~2010-03-20 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 18:20 [PATCH 0/5] x86: Merge fpu and simd exception handlers Brian Gerst
2010-03-18 18:20 ` [PATCH 1/5] x86-32: Split cache flush handler from simd handler Brian Gerst
2010-03-19 22:33 ` H. Peter Anvin
2010-03-20 4:08 ` Brian Gerst
2010-03-20 4:55 ` H. Peter Anvin
2010-03-20 18:53 ` H. Peter Anvin [this message]
2010-03-18 18:20 ` [PATCH 2/5] x86-32: Remove die_if_kernel() Brian Gerst
2010-03-18 18:20 ` [PATCH 3/5] x86: Merge simd_math_error() into math_error() Brian Gerst
2010-03-18 18:20 ` [PATCH 4/5] x86: Merge kernel_math_error() " Brian Gerst
2010-03-18 18:20 ` [PATCH 5/5] x86-32: Don't set ignore_fpu_irq in simd exception Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA519A3.3000605@kernel.org \
--to=hpa@kernel.org \
--cc=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox