From: Randy Dunlap <rdunlap@xenotime.net>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-pci <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] panic: Add taint flag TAINT_FIRMWARE_WORKAROUND ('I')
Date: Sat, 20 Mar 2010 18:56:36 -0700 [thread overview]
Message-ID: <4BA57CD4.6020906@xenotime.net> (raw)
In-Reply-To: <1269126410.18314.116.camel@localhost>
On 03/20/10 16:06, Ben Hutchings wrote:
> This taint flag will initially be used when warning about invalid ACPI
> DMAR tables.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> include/linux/kernel.h | 1 +
> kernel/panic.c | 2 ++
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index eaf7221..ab8072b 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -344,6 +344,7 @@ extern enum system_states {
> #define TAINT_OVERRIDDEN_ACPI_TABLE 8
> #define TAINT_WARN 9
> #define TAINT_CRAP 10
> +#define TAINT_FIRMWARE_WORKAROUND 11
>
> extern void dump_stack(void) __cold;
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 8b821bc..e9fa224 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -178,6 +178,7 @@ static const struct tnt tnts[] = {
> { TAINT_OVERRIDDEN_ACPI_TABLE, 'A', ' ' },
> { TAINT_WARN, 'W', ' ' },
> { TAINT_CRAP, 'C', ' ' },
> + { TAINT_FIRMWARE_WORKAROUND, 'I', ' ' },
> };
>
> /**
> @@ -194,6 +195,7 @@ static const struct tnt tnts[] = {
> * 'A' - ACPI table overridden.
> * 'W' - Taint on warning.
> * 'C' - modules from drivers/staging are loaded.
> + * 'I' - Firmware workaround was required.
> *
> * The string is overwritten by the next call to print_tainted().
> */
Please update Documentation/oops-tracing.txt also.
thanks,
--
~Randy
next prev parent reply other threads:[~2010-03-21 1:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 23:01 [PATCH 1/4] pci/dmar: Combine the BIOS DMAR table warning messages Ben Hutchings
2010-03-20 23:05 ` [PATCH 2/4] panic: Allow taint flag for warnings to be changed from TAINT_WARN Ben Hutchings
2010-03-21 19:10 ` Andi Kleen
2010-03-21 19:25 ` Ben Hutchings
2010-03-23 2:47 ` Andrew Morton
2010-03-23 13:20 ` Ben Hutchings
2010-03-23 7:45 ` Paul Mundt
2010-03-23 13:23 ` Ben Hutchings
2010-03-24 11:11 ` Michael Ellerman
2010-03-20 23:06 ` [PATCH 3/4] panic: Add taint flag TAINT_FIRMWARE_WORKAROUND ('I') Ben Hutchings
2010-03-21 1:56 ` Randy Dunlap [this message]
2010-03-20 23:07 ` [PATCH 4/4] pci/dmar: Tone down warnings about invalid BIOS DMAR tables Ben Hutchings
2010-03-21 8:43 ` David Woodhouse
2010-03-21 14:57 ` Ben Hutchings
2010-03-21 15:57 ` David Woodhouse
2010-03-23 2:46 ` [PATCH 1/4] pci/dmar: Combine the BIOS DMAR table warning messages Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA57CD4.6020906@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox