From: Lars Lindley <lindley@coyote.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Carpenter <error27@gmail.com>,
gregkh@suse.de, greg@kroah.com, harvey.harrison@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: reg.c Coding style fixes.
Date: Sun, 21 Mar 2010 16:40:45 +0100 [thread overview]
Message-ID: <4BA63DFD.4010803@coyote.org> (raw)
In-Reply-To: <4BA61384.3030005@cs.helsinki.fi>
Hi Pekka
I will check them more in the future.
I will come back with a new patch against master that combines the two commits
as soon as I get my head around how to get git to combine them.. :)
(And paint the little room in the appartment.. :)
/Lars
On 2010-03-21 13:39, Pekka Enberg wrote:
> Pavel Machek wrote:
>>> [PATCH] staging: winbond: reg.c Fix accidental commenting of msleep(10)
>>>
>>> I accidentaly commented out msleep() in one place.
>>> This applies after previous patch:
>>> Message-Id: <1269098051-6594-1-git-send-email-lindley@coyote.org>
>>>
>>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>>
>> Ack. but you probably want to merge those two pieces together.
>
> Yes. Like I said before, please _check_ the result before posting your
> patches. It's very easy to make silly mistakes in "trivial" patches like
> these. Remember, it's not about quantity, it's about quality of each
> individual patch no matter how trivial they might seem at first.
>
> Pekka
>
next prev parent reply other threads:[~2010-03-21 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 15:14 [PATCH] staging: winbond: reg.c Coding style fixes Lars Lindley
2010-03-20 16:24 ` Dan Carpenter
2010-03-20 19:21 ` Lars Lindley
2010-03-21 6:58 ` Pavel Machek
2010-03-21 12:39 ` Pekka Enberg
2010-03-21 15:40 ` Lars Lindley [this message]
2010-03-21 9:14 ` Dan Carpenter
2010-03-21 10:55 ` strip_whitespace.pl Dan Carpenter
2010-03-21 11:07 ` strip_whitespace.pl Dan Carpenter
2010-03-21 15:31 ` strip_whitespace.pl Lars Lindley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA63DFD.4010803@coyote.org \
--to=lindley@coyote.org \
--cc=devel@driverdev.osuosl.org \
--cc=error27@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox