From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, pavel@ucw.cz,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
Date: Mon, 22 Mar 2010 09:16:25 +0200 [thread overview]
Message-ID: <4BA71949.9040809@cs.helsinki.fi> (raw)
In-Reply-To: <1269210658-9518-1-git-send-email-lindley@coyote.org>
Lars Lindley kirjoitti:
> I fixed the checkpatch things except a couple of long lines.
> I also removed hungarian notation from the argument names
> and some "commented away" code.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
Did you check that all these function declarations are actually used?
I've spotted plenty of dead code in the past.
> +/*
> + * ====================================
> + * Interface function declare
> + * ====================================
> + */
> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
see the same thing elsewhere in this patch as well.
next prev parent reply other threads:[~2010-03-22 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 22:30 [PATCH] staging: winbond: wb35reg_f.h Coding style fixes Lars Lindley
2010-03-22 7:16 ` Pekka Enberg [this message]
2010-03-22 9:45 ` Lars Lindley
2010-03-22 9:57 ` Pekka Enberg
2010-03-22 10:55 ` Lars Lindley
2010-03-22 10:56 ` Pekka Enberg
2010-03-22 10:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA71949.9040809@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox