* [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
@ 2010-03-21 22:30 Lars Lindley
2010-03-22 7:16 ` Pekka Enberg
0 siblings, 1 reply; 7+ messages in thread
From: Lars Lindley @ 2010-03-21 22:30 UTC (permalink / raw)
To: gregkh, greg, penberg, pavel; +Cc: devel, linux-kernel, Lars Lindley
I fixed the checkpatch things except a couple of long lines.
I also removed hungarian notation from the argument names
and some "commented away" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
---
drivers/staging/winbond/wb35reg_f.h | 104 ++++++++++++++++++-----------------
1 files changed, 54 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h
index d352bce..1c1e3d8 100644
--- a/drivers/staging/winbond/wb35reg_f.h
+++ b/drivers/staging/winbond/wb35reg_f.h
@@ -3,59 +3,63 @@
#include "wbhal_s.h"
-//====================================
-// Interface function declare
-//====================================
-unsigned char Wb35Reg_initial( struct hw_data * pHwData );
-void Uxx_power_on_procedure( struct hw_data * pHwData );
-void Uxx_power_off_procedure( struct hw_data * pHwData );
-void Uxx_ReadEthernetAddress( struct hw_data * pHwData );
-void Dxx_initial( struct hw_data * pHwData );
-void Mxx_initial( struct hw_data * pHwData );
-void RFSynthesizer_initial( struct hw_data * pHwData );
-//void RFSynthesizer_SwitchingChannel( struct hw_data * pHwData, s8 Channel );
-void RFSynthesizer_SwitchingChannel( struct hw_data * pHwData, struct chan_info Channel );
-void BBProcessor_initial( struct hw_data * pHwData );
-void BBProcessor_RateChanging( struct hw_data * pHwData, u8 rate ); // 20060613.1
-//void RF_RateChanging( struct hw_data * pHwData, u8 rate ); // 20060626.5.c Add
-u8 RFSynthesizer_SetPowerIndex( struct hw_data * pHwData, u8 PowerIndex );
-u8 RFSynthesizer_SetMaxim2828_24Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2828_50Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2827_24Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2827_50Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2825Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetAiroha2230Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetAiroha7230Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetWinbond242Power( struct hw_data *, u8 index );
-void GetTxVgaFromEEPROM( struct hw_data * pHwData );
-void EEPROMTxVgaAdjust( struct hw_data * pHwData ); // 20060619.5 Add
-
-#define RFWriteControlData( _A, _V ) Wb35Reg_Write( _A, 0x0864, _V )
-
-void Wb35Reg_destroy( struct hw_data * pHwData );
-
-unsigned char Wb35Reg_Read( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterValue );
-unsigned char Wb35Reg_ReadSync( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterValue );
-unsigned char Wb35Reg_Write( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char Wb35Reg_WriteSync( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char Wb35Reg_WriteWithCallbackValue( struct hw_data * pHwData,
- u16 RegisterNo,
- u32 RegisterValue,
- s8 *pValue,
- s8 Len);
-unsigned char Wb35Reg_BurstWrite( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterData, u8 NumberOfData, u8 Flag );
-
-void Wb35Reg_EP0VM( struct hw_data * pHwData );
-void Wb35Reg_EP0VM_start( struct hw_data * pHwData );
+/*
+ * ====================================
+ * Interface function declare
+ * ====================================
+ */
+unsigned char Wb35Reg_initial(struct hw_data *HwData);
+void Uxx_power_on_procedure(struct hw_data *HwData);
+void Uxx_power_off_procedure(struct hw_data *HwData);
+void Uxx_ReadEthernetAddress(struct hw_data *HwData);
+void Dxx_initial(struct hw_data *HwData);
+void Mxx_initial(struct hw_data *HwData);
+void RFSynthesizer_initial(struct hw_data *HwData);
+void RFSynthesizer_SwitchingChannel(struct hw_data *HwData, struct chan_info Channel);
+void BBProcessor_initial(struct hw_data *HwData);
+void BBProcessor_RateChanging(struct hw_data *HwData, u8 rate);
+u8 RFSynthesizer_SetPowerIndex(struct hw_data *HwData, u8 PowerIndex);
+u8 RFSynthesizer_SetMaxim2828_24Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2828_50Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2827_24Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2827_50Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2825Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetAiroha2230Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetAiroha7230Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetWinbond242Power(struct hw_data *, u8 index);
+void GetTxVgaFromEEPROM(struct hw_data *HwData);
+void EEPROMTxVgaAdjust(struct hw_data *HwData);
+
+#define RFWriteControlData(_A, _V) Wb35Reg_Write(_A, 0x0864, _V)
+
+void Wb35Reg_destroy(struct hw_data *HwData);
+
+unsigned char Wb35Reg_Read(struct hw_data *HwData, u16 RegisterNo, u32 *RegisterValue);
+unsigned char Wb35Reg_ReadSync(struct hw_data *HwData, u16 RegisterNo, u32 *RegisterValue);
+unsigned char Wb35Reg_Write(struct hw_data *HwData, u16 RegisterNo, u32 RegisterValue);
+unsigned char Wb35Reg_WriteSync(struct hw_data *HwData, u16 RegisterNo, u32 RegisterValue);
+unsigned char Wb35Reg_WriteWithCallbackValue(struct hw_data *HwData,
+ u16 RegisterNo,
+ u32 RegisterValue,
+ s8 *Value,
+ s8 Len);
+unsigned char Wb35Reg_BurstWrite(struct hw_data *HwData,
+ u16 RegisterNo,
+ u32 *RegisterData,
+ u8 NumberOfData,
+ u8 Flag);
+
+void Wb35Reg_EP0VM(struct hw_data *HwData);
+void Wb35Reg_EP0VM_start(struct hw_data *HwData);
void Wb35Reg_EP0VM_complete(struct urb *urb);
-u32 BitReverse( u32 dwData, u32 DataLength);
+u32 BitReverse(u32 Data, u32 DataLength);
-void CardGetMulticastBit( u8 Address[MAC_ADDR_LENGTH], u8 *Byte, u8 *Value );
-u32 CardComputeCrc( u8 * Buffer, u32 Length );
+void CardGetMulticastBit(u8 Address[MAC_ADDR_LENGTH], u8 *Byte, u8 *Value);
+u32 CardComputeCrc(u8 *Buffer, u32 Length);
-void Wb35Reg_phy_calibration( struct hw_data * pHwData );
-void Wb35Reg_Update( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char adjust_TXVGA_for_iq_mag( struct hw_data * pHwData );
+void Wb35Reg_phy_calibration(struct hw_data *HwData);
+void Wb35Reg_Update(struct hw_data *HwData, u16 RegisterNo, u32 RegisterValue);
+unsigned char adjust_TXVGA_for_iq_mag(struct hw_data *HwData);
#endif
--
1.7.0.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
2010-03-21 22:30 [PATCH] staging: winbond: wb35reg_f.h Coding style fixes Lars Lindley
@ 2010-03-22 7:16 ` Pekka Enberg
2010-03-22 9:45 ` Lars Lindley
0 siblings, 1 reply; 7+ messages in thread
From: Pekka Enberg @ 2010-03-22 7:16 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, pavel, devel, linux-kernel
Lars Lindley kirjoitti:
> I fixed the checkpatch things except a couple of long lines.
> I also removed hungarian notation from the argument names
> and some "commented away" code.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
Did you check that all these function declarations are actually used?
I've spotted plenty of dead code in the past.
> +/*
> + * ====================================
> + * Interface function declare
> + * ====================================
> + */
> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
see the same thing elsewhere in this patch as well.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
2010-03-22 7:16 ` Pekka Enberg
@ 2010-03-22 9:45 ` Lars Lindley
2010-03-22 9:57 ` Pekka Enberg
0 siblings, 1 reply; 7+ messages in thread
From: Lars Lindley @ 2010-03-22 9:45 UTC (permalink / raw)
To: Pekka Enberg; +Cc: gregkh, greg, pavel, devel, linux-kernel
On 2010-03-22 08:16, Pekka Enberg wrote:
> Lars Lindley kirjoitti:
>> I fixed the checkpatch things except a couple of long lines.
>> I also removed hungarian notation from the argument names
>> and some "commented away" code.
>>
>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>
> Did you check that all these function declarations are actually used?
> I've spotted plenty of dead code in the past.
>
Nope, didn't check that. Just looking at the style now..
>> +/*
>> + * ====================================
>> + * Interface function declare
>> + * ====================================
>> + */
>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
>
> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
> see the same thing elsewhere in this patch as well.
>
I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
CamelCase alone for now. I can make it like that if you want..
/Lars
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
2010-03-22 9:45 ` Lars Lindley
@ 2010-03-22 9:57 ` Pekka Enberg
2010-03-22 10:55 ` Lars Lindley
0 siblings, 1 reply; 7+ messages in thread
From: Pekka Enberg @ 2010-03-22 9:57 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, pavel, devel, linux-kernel
On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@coyote.org> wrote:
> On 2010-03-22 08:16, Pekka Enberg wrote:
>> Lars Lindley kirjoitti:
>>> I fixed the checkpatch things except a couple of long lines.
>>> I also removed hungarian notation from the argument names
>>> and some "commented away" code.
>>>
>>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>>
>> Did you check that all these function declarations are actually used?
>> I've spotted plenty of dead code in the past.
>>
> Nope, didn't check that. Just looking at the style now..
Well, based on my experience, you're will do a lot of unnecessary work
on code that's going to get removed because it's not actually used.
That's why I haven't bothered with style cleanups much.
>>> +/*
>>> + * ====================================
>>> + * Interface function declare
>>> + * ====================================
>>> + */
>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
>>
>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
>> see the same thing elsewhere in this patch as well.
>>
> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
> CamelCase alone for now. I can make it like that if you want..
Yes please.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
2010-03-22 9:57 ` Pekka Enberg
@ 2010-03-22 10:55 ` Lars Lindley
2010-03-22 10:56 ` Pekka Enberg
2010-03-22 10:58 ` Pavel Machek
0 siblings, 2 replies; 7+ messages in thread
From: Lars Lindley @ 2010-03-22 10:55 UTC (permalink / raw)
To: Pekka Enberg; +Cc: gregkh, greg, pavel, devel, linux-kernel
On 2010-03-22 10:57, Pekka Enberg wrote:
> On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@coyote.org> wrote:
>> On 2010-03-22 08:16, Pekka Enberg wrote:
>>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
>>>
>>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
>>> see the same thing elsewhere in this patch as well.
>>>
>> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
>> CamelCase alone for now. I can make it like that if you want..
>
> Yes please.
>
Here's a new patch against master that fixes CamelCase too.
[PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
I fixed the checkpatch things except a couple of long lines.
I also removed hungarian notation and CamelCase from the argument names
and some "commented away" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
---
drivers/staging/winbond/wb35reg_f.h | 104 ++++++++++++++++++-----------------
1 files changed, 54 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h
index d352bce..bf23c10 100644
--- a/drivers/staging/winbond/wb35reg_f.h
+++ b/drivers/staging/winbond/wb35reg_f.h
@@ -3,59 +3,63 @@
#include "wbhal_s.h"
-//====================================
-// Interface function declare
-//====================================
-unsigned char Wb35Reg_initial( struct hw_data * pHwData );
-void Uxx_power_on_procedure( struct hw_data * pHwData );
-void Uxx_power_off_procedure( struct hw_data * pHwData );
-void Uxx_ReadEthernetAddress( struct hw_data * pHwData );
-void Dxx_initial( struct hw_data * pHwData );
-void Mxx_initial( struct hw_data * pHwData );
-void RFSynthesizer_initial( struct hw_data * pHwData );
-//void RFSynthesizer_SwitchingChannel( struct hw_data * pHwData, s8 Channel );
-void RFSynthesizer_SwitchingChannel( struct hw_data * pHwData, struct chan_info Channel );
-void BBProcessor_initial( struct hw_data * pHwData );
-void BBProcessor_RateChanging( struct hw_data * pHwData, u8 rate ); // 20060613.1
-//void RF_RateChanging( struct hw_data * pHwData, u8 rate ); // 20060626.5.c Add
-u8 RFSynthesizer_SetPowerIndex( struct hw_data * pHwData, u8 PowerIndex );
-u8 RFSynthesizer_SetMaxim2828_24Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2828_50Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2827_24Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2827_50Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2825Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetAiroha2230Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetAiroha7230Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetWinbond242Power( struct hw_data *, u8 index );
-void GetTxVgaFromEEPROM( struct hw_data * pHwData );
-void EEPROMTxVgaAdjust( struct hw_data * pHwData ); // 20060619.5 Add
-
-#define RFWriteControlData( _A, _V ) Wb35Reg_Write( _A, 0x0864, _V )
-
-void Wb35Reg_destroy( struct hw_data * pHwData );
-
-unsigned char Wb35Reg_Read( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterValue );
-unsigned char Wb35Reg_ReadSync( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterValue );
-unsigned char Wb35Reg_Write( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char Wb35Reg_WriteSync( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char Wb35Reg_WriteWithCallbackValue( struct hw_data * pHwData,
- u16 RegisterNo,
- u32 RegisterValue,
- s8 *pValue,
- s8 Len);
-unsigned char Wb35Reg_BurstWrite( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterData, u8 NumberOfData, u8 Flag );
-
-void Wb35Reg_EP0VM( struct hw_data * pHwData );
-void Wb35Reg_EP0VM_start( struct hw_data * pHwData );
+/*
+ * ====================================
+ * Interface function declare
+ * ====================================
+ */
+unsigned char Wb35Reg_initial(struct hw_data *hw_data);
+void Uxx_power_on_procedure(struct hw_data *hw_data);
+void Uxx_power_off_procedure(struct hw_data *hw_data);
+void Uxx_ReadEthernetAddress(struct hw_data *hw_data);
+void Dxx_initial(struct hw_data *hw_data);
+void Mxx_initial(struct hw_data *hw_data);
+void RFSynthesizer_initial(struct hw_data *hw_data);
+void RFSynthesizer_SwitchingChannel(struct hw_data *hw_data, struct chan_info channel);
+void BBProcessor_initial(struct hw_data *hw_data);
+void BBProcessor_RateChanging(struct hw_data *hw_data, u8 rate);
+u8 RFSynthesizer_SetPowerIndex(struct hw_data *hw_data, u8 power_index);
+u8 RFSynthesizer_SetMaxim2828_24Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2828_50Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2827_24Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2827_50Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2825Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetAiroha2230Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetAiroha7230Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetWinbond242Power(struct hw_data *, u8 index);
+void GetTxVgaFromEEPROM(struct hw_data *hw_data);
+void EEPROMTxVgaAdjust(struct hw_data *hw_data);
+
+#define RFWriteControlData(_A, _V) Wb35Reg_Write(_A, 0x0864, _V)
+
+void Wb35Reg_destroy(struct hw_data *hw_data);
+
+unsigned char Wb35Reg_Read(struct hw_data *hw_data, u16 register_no, u32 *register_value);
+unsigned char Wb35Reg_ReadSync(struct hw_data *hw_data, u16 register_no, u32 *register_value);
+unsigned char Wb35Reg_Write(struct hw_data *hw_data, u16 register_no, u32 register_value);
+unsigned char Wb35Reg_WriteSync(struct hw_data *hw_data, u16 register_no, u32 register_value);
+unsigned char Wb35Reg_WriteWithCallbackValue(struct hw_data *hw_data,
+ u16 register_no,
+ u32 register_value,
+ s8 *value,
+ s8 len);
+unsigned char Wb35Reg_BurstWrite(struct hw_data *hw_data,
+ u16 register_no,
+ u32 *register_data,
+ u8 number_of_data,
+ u8 flag);
+
+void Wb35Reg_EP0VM(struct hw_data *hw_data);
+void Wb35Reg_EP0VM_start(struct hw_data *hw_data);
void Wb35Reg_EP0VM_complete(struct urb *urb);
-u32 BitReverse( u32 dwData, u32 DataLength);
+u32 BitReverse(u32 data, u32 data_length);
-void CardGetMulticastBit( u8 Address[MAC_ADDR_LENGTH], u8 *Byte, u8 *Value );
-u32 CardComputeCrc( u8 * Buffer, u32 Length );
+void CardGetMulticastBit(u8 address[MAC_ADDR_LENGTH], u8 *byte, u8 *value);
+u32 CardComputeCrc(u8 *buffer, u32 length);
-void Wb35Reg_phy_calibration( struct hw_data * pHwData );
-void Wb35Reg_Update( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char adjust_TXVGA_for_iq_mag( struct hw_data * pHwData );
+void Wb35Reg_phy_calibration(struct hw_data *hw_data);
+void Wb35Reg_Update(struct hw_data *hw_data, u16 register_no, u32 register_value);
+unsigned char adjust_TXVGA_for_iq_mag(struct hw_data *hw_data);
#endif
--
1.7.0.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
2010-03-22 10:55 ` Lars Lindley
@ 2010-03-22 10:56 ` Pekka Enberg
2010-03-22 10:58 ` Pavel Machek
1 sibling, 0 replies; 7+ messages in thread
From: Pekka Enberg @ 2010-03-22 10:56 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, pavel, devel, linux-kernel
On Mon, Mar 22, 2010 at 12:55 PM, Lars Lindley <lindley@coyote.org> wrote:
> Here's a new patch against master that fixes CamelCase too.
>
> [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
>
> I fixed the checkpatch things except a couple of long lines.
> I also removed hungarian notation and CamelCase from the argument names
> and some "commented away" code.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
2010-03-22 10:55 ` Lars Lindley
2010-03-22 10:56 ` Pekka Enberg
@ 2010-03-22 10:58 ` Pavel Machek
1 sibling, 0 replies; 7+ messages in thread
From: Pavel Machek @ 2010-03-22 10:58 UTC (permalink / raw)
To: Lars Lindley; +Cc: Pekka Enberg, gregkh, greg, devel, linux-kernel
> On 2010-03-22 10:57, Pekka Enberg wrote:
> > On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@coyote.org> wrote:
> >> On 2010-03-22 08:16, Pekka Enberg wrote:
> >>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
> >>>
> >>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
> >>> see the same thing elsewhere in this patch as well.
> >>>
> >> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
> >> CamelCase alone for now. I can make it like that if you want..
> >
> > Yes please.
> >
>
>
> Here's a new patch against master that fixes CamelCase too.
>
>
>
> [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
>
> I fixed the checkpatch things except a couple of long lines.
> I also removed hungarian notation and CamelCase from the argument names
> and some "commented away" code.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-22 10:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-21 22:30 [PATCH] staging: winbond: wb35reg_f.h Coding style fixes Lars Lindley
2010-03-22 7:16 ` Pekka Enberg
2010-03-22 9:45 ` Lars Lindley
2010-03-22 9:57 ` Pekka Enberg
2010-03-22 10:55 ` Lars Lindley
2010-03-22 10:56 ` Pekka Enberg
2010-03-22 10:58 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox