From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678Ab0CVMF5 (ORCPT ); Mon, 22 Mar 2010 08:05:57 -0400 Received: from daytona.panasas.com ([67.152.220.89]:13183 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752315Ab0CVMFz (ORCPT ); Mon, 22 Mar 2010 08:05:55 -0400 Message-ID: <4BA75D20.2060905@panasas.com> Date: Mon, 22 Mar 2010 14:05:52 +0200 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3 MIME-Version: 1.0 To: Nick Piggin CC: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [rfc][patch] mm, fs: warn on missing address space operations References: <20100322053937.GA17637@laptop> <4BA7359B.2060603@panasas.com> <20100322105442.GH17637@laptop> In-Reply-To: <20100322105442.GH17637@laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 22 Mar 2010 12:05:54.0420 (UTC) FILETIME=[05EF1340:01CAC9B8] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2010 12:54 PM, Nick Piggin wrote: > On Mon, Mar 22, 2010 at 11:17:15AM +0200, Boaz Harrosh wrote: >> --- >> git diff --stat -p -M fs/exofs/inode.c >> fs/exofs/inode.c | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c >> index a17e4b7..85dd847 100644 >> --- a/fs/exofs/inode.c >> +++ b/fs/exofs/inode.c >> @@ -754,6 +754,11 @@ static int exofs_write_end(struct file *file, struct address_space *mapping, >> return ret; >> } >> >> +static int exofs_releasepage(struct page *page, gfp_t gfp) >> +{ >> + return try_to_free_buffers(page); >> +} >> + >> const struct address_space_operations exofs_aops = { >> .readpage = exofs_readpage, >> .readpages = exofs_readpages, >> @@ -761,6 +766,9 @@ const struct address_space_operations exofs_aops = { >> .writepages = exofs_writepages, >> .write_begin = exofs_write_begin_export, >> .write_end = exofs_write_end, >> + .releasepage = exofs_releasepage, >> + .set_page_dirty = __set_page_dirty_buffers, >> + .invalidatepage = block_invalidatepage, >> }; > > AFAIKS, you aren't using buffer heads at all (except nobh_truncate, > which will not attach buffers to pages)? > > If so, you should only need __set_page_dirty_nobuffers. > Ho, thanks, that one is much better, yes. BTW: The use of nobh_truncate, I hope will go away after your: fs: truncate introduce new sequence with these two helpers you added I can actually get rid of that as well. (I think. I keep postponing this work ;-)) > Thanks, > Nick > Thanks Boaz