public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Kosin <jkosin@intcomgrp.com>
To: linux-kernel@vger.kernel.org
Subject: [OT] Style Issues / Concerns
Date: Mon, 22 Mar 2010 16:02:13 -0400	[thread overview]
Message-ID: <4BA7CCC5.5020302@intcomgrp.com> (raw)

Everyone,

1) Please forgive me if this is the wrong forum to post this.

2) Please CC me when replying... I'm having list issues right now.

3) Questions / Concerns:

I'm a bit confused as to why there has been a style push to remove
braces {} from the code.

Long ago, code was often missing these braces for exactly the point many
patches are now coming back and reverting back to this antiquated style.

The problem was, and the reason the style changed to include these
braces, was to prevent the common problem of forgetting the braces when
adding another statement to the if or else block of the code.

Example:

if( (x != 0) )
    flag = true;
else
    flag = false;

----

if( (x != 0) )
    flag = true;
    call_something();
else
    flag = false;

----

Before everyone jumps in at once, this is a simple example that will
produce a compiler error about the misplaced else.  However if there are
many if statements above this that may allow the else to be paired up
with it then the code will compile and there will be a serious and very
difficult bug in the code that will take days or months to find.

Why has the style for this changed back?
Does the compiler produce smaller code without the braces {}?

Just my 2-cents,
James Kosin


             reply	other threads:[~2010-03-22 20:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22 20:02 James Kosin [this message]
2010-03-22 20:13 ` [OT] Style Issues / Concerns Andi Kleen
2010-03-22 20:33   ` James Kosin
2010-03-22 20:55     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA7CCC5.5020302@intcomgrp.com \
    --to=jkosin@intcomgrp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox