* [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr()
@ 2010-03-22 20:48 Roel Kluin
2010-03-22 23:12 ` Jing Huang
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-03-22 20:48 UTC (permalink / raw)
To: Jing Huang, linux-scsi, Andrew Morton, LKML
It appears that the wrong fcport H2I message was tested
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Was this intended?
diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c
index c589488..5e5e6fe 100644
--- a/drivers/scsi/bfa/bfa_fcport.c
+++ b/drivers/scsi/bfa/bfa_fcport.c
@@ -1281,7 +1281,7 @@ bfa_fcport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)
break;
case BFI_FCPORT_I2H_DISABLE_RSP:
- if (fcport->msgtag == i2hmsg.penable_rsp->msgtag)
+ if (fcport->msgtag == i2hmsg.pdisable_rsp->msgtag)
bfa_sm_send_event(fcport, BFA_FCPORT_SM_FWRSP);
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr()
2010-03-22 20:48 [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr() Roel Kluin
@ 2010-03-22 23:12 ` Jing Huang
0 siblings, 0 replies; 2+ messages in thread
From: Jing Huang @ 2010-03-22 23:12 UTC (permalink / raw)
To: Roel Kluin, linux-scsi@vger.kernel.org, Andrew Morton, LKML
This is not intended. Using penable_rsp or pdisable_rsp in this case doesn't have functional difference since it is a union, but it is confusing and should be fixed.
Thanks
Jing
-----Original Message-----
From: Roel Kluin [mailto:roel.kluin@gmail.com]
Sent: Monday, March 22, 2010 1:49 PM
To: Jing Huang; linux-scsi@vger.kernel.org; Andrew Morton; LKML
Subject: [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr()
It appears that the wrong fcport H2I message was tested
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Was this intended?
diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c
index c589488..5e5e6fe 100644
--- a/drivers/scsi/bfa/bfa_fcport.c
+++ b/drivers/scsi/bfa/bfa_fcport.c
@@ -1281,7 +1281,7 @@ bfa_fcport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)
break;
case BFI_FCPORT_I2H_DISABLE_RSP:
- if (fcport->msgtag == i2hmsg.penable_rsp->msgtag)
+ if (fcport->msgtag == i2hmsg.pdisable_rsp->msgtag)
bfa_sm_send_event(fcport, BFA_FCPORT_SM_FWRSP);
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-22 23:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-22 20:48 [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr() Roel Kluin
2010-03-22 23:12 ` Jing Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox