Re: [PATCH 2/6] drivers:misc: Kconfig, Makefile for TI's ST ldisc

Greg KH
2010-03-24T02:26:07Z

On Tue, Mar 23, 2010 at 03:18:52PM +0000, Alan Cox wrote:
> On Mon, 22 Mar 2010 14:35:30 -0700
> Greg KH <gregkh@suse.de> wrote:
>
> > On Mon, Mar 22, 2010 at 04:19:12PM -0500, pavan_savoy@ti.com wrote:
> > > From: Pavan Savoy <pavan_savoy@ti.com>
> > >
> > > This change adds the Kconfig and Make file for TI's
> > > ST line discipline driver and the BlueZ driver for BT
> > > core of the TI BT/FM/GPS combo chip.
> > >
> > > Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> > > ---
> > > drivers/misc/Kconfig | 1 +
> >
> > Why 'misc'? Why not 'char' like all the other ldiscs?
> >
> > Or 'drivers/ldisc' to be more specific?
>
> We've discussed having /tty or drivers/tty for a while. The ldiscs are
> currently everywhere - drivers/net, isdn, char ....
>
> I am not sure an ldisc directory helps though - slip and ppp are in
> drivers/net for example and clearly belong there.

Yeah, good point. I like the idea of a tty/ directory for the tty core
in the future if it's really needed.

thanks,

greg k-h