From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754831Ab0CWPlv (ORCPT ); Tue, 23 Mar 2010 11:41:51 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:42150 "EHLO rcsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384Ab0CWPlu (ORCPT ); Tue, 23 Mar 2010 11:41:50 -0400 Message-ID: <4BA8E0F8.4050708@oracle.com> Date: Tue, 23 Mar 2010 08:40:40 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: William Cohen CC: Randy Dunlap , LKML Subject: Re: [PATCH] Make kernel-doc ignore __init_or_module References: <4BA8DEEA.7090102@redhat.com> In-Reply-To: <4BA8DEEA.7090102@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4BA8E106.0101:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/10 08:31, William Cohen wrote: > > Function definitions may include __init_or_module. kernel-doc needs to > filter those out to avoid confusing __init_or_module for the function name. > > Signed-off-by: William cohen > --- > scripts/kernel-doc | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/scripts/kernel-doc b/scripts/kernel-doc > index c7865c3..1d8db58 100755 > --- a/scripts/kernel-doc > +++ b/scripts/kernel-doc > @@ -1728,6 +1728,7 @@ sub dump_function($$) { > $prototype =~ s/^noinline +//; > $prototype =~ s/__devinit +//; > $prototype =~ s/__init +//; > + $prototype =~ s/__init_or_module +//; > $prototype =~ s/^#\s*define\s+//; #ak added > $prototype =~ s/__attribute__\s*\(\([a-z,]*\)\)//; > Hi, Yes, I know. I've already sent this patch to Linus more than once and now Andrew has it for merging... -- ~Randy