Re: [PATCH -v4 00/08] use lmb with x86

[Yinghai Lu <yinghai@kernel.org>]

On 03/24/2010 04:41 AM, Michael Ellerman wrote:
> On Wed, 2010-03-24 at 11:48 +0100, Ingo Molnar wrote:
>> * Yinghai Lu <yinghai@kernel.org> wrote:
>>
>>> new early_res is lmb extension. and it could be used to replace bootmem.
>>
>> Why not do what we suggested: extend lmb.c to also offer the 
>> early_res-equivalent functionality, and remove kernel/early_res.c and move 
>> lib/lmb.c to mm/lmb.c?
>>
>> We dont want two facilities (early_res and lmb) really ...
> 
> Exactly. 
> 
> This series seems to leave us with kernel/early_res.c (which should
> never have moved out of arch/x86 AFAICS) - as well as using some of
> lmb.c.
the new version...
http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-2.6-yinghai.git;a=blob;f=kernel/early_res.c;h=a7933939b44ae1ccb72e30203031f5b742c88a3f;hb=c9115b0731084ec0c0e164456b7434ea61c2a67b

should be clean.

> 
> It doesn't compile on powerpc, because early_res.c is looking for
> find_fw_memmap_area() which is still under arch/x86.

it looks that you are looking at old version somehow.

please check
http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-2.6-yinghai.git;a=summary

> 
> And sprinkling CONFIG_NO_BOOTMEM everywhere is getting a bit gross. I
> notice that's already happened to mm/(bootmem|page_alloc).c but
> propagating it further is not nice.

for converting smoothly, before we remove bootmem core, we can keep it. and can compare bootmem and nobootmem side by side.

Thanks

Yinghai