From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: isdn@linux-pingi.de, davem@davemloft.net,
linux@dominikbrodowski.net, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
Date: Thu, 25 Mar 2010 15:08:37 +0100 [thread overview]
Message-ID: <4BAB6E65.7@nachtwindheim.de> (raw)
In-Reply-To: <20100325121610.GB5069@pengutronix.de>
Wolfram Sang schrieb:
> Hi Henrik,
>
> thanks for the work. Please, just keep the placement of those attributes
> consistent. Otherwise it might be easy to miss:
>
>
>> -static int sedlbauer_config(struct pcmcia_device *link);
>> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
>>
>
> Wrong.
>
>
>> -static int sedlbauer_probe(struct pcmcia_device *link)
>> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
>> {
>>
>
> Right.
>
> (I think checkpatch checks for this, too)
No, checkpatch doesn't claim about that.
Greets, Henrik
prev parent reply other threads:[~2010-03-25 14:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
2010-03-25 12:16 ` Karsten Keil
2010-03-25 12:15 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Karsten Keil
2010-03-25 12:14 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Karsten Keil
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
2010-03-25 17:02 ` Dominik Brodowski
2010-03-25 18:45 ` David Miller
2010-03-25 18:55 ` David Miller
2010-03-25 18:58 ` David Miller
2010-03-26 0:59 ` Henrik Kretzschmar
2010-03-26 3:27 ` David Miller
2010-03-26 13:56 ` Henrik Kretzschmar
2010-03-26 16:46 ` David Miller
2010-03-25 12:16 ` Wolfram Sang
2010-03-25 14:05 ` Henrik Kretzschmar
2010-03-25 14:17 ` Wolfram Sang
2010-03-25 14:08 ` Henrik Kretzschmar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB6E65.7@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox