* [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
@ 2010-03-25 12:05 Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
` (2 more replies)
0 siblings, 3 replies; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-25 12:05 UTC (permalink / raw)
To: isdn; +Cc: davem, linux, akpm, linux-kernel, Henrik Kretzschmar
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.
WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
in reference from the function sedlbauer_config() to the function
.devinit.text:hisax_init_pcmcia()
The function sedlbauer_config() references
the function __devinit hisax_init_pcmcia().
This is often because sedlbauer_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
drivers/isdn/hisax/sedlbauer_cs.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/hisax/sedlbauer_cs.c b/drivers/isdn/hisax/sedlbauer_cs.c
index 7836ec3..71b3dde 100644
--- a/drivers/isdn/hisax/sedlbauer_cs.c
+++ b/drivers/isdn/hisax/sedlbauer_cs.c
@@ -76,7 +76,7 @@ module_param(protocol, int, 0);
event handler.
*/
-static int sedlbauer_config(struct pcmcia_device *link);
+static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
static void sedlbauer_release(struct pcmcia_device *link);
/*
@@ -85,7 +85,7 @@ static void sedlbauer_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/
-static void sedlbauer_detach(struct pcmcia_device *p_dev);
+static void sedlbauer_detach(struct pcmcia_device *p_dev) __devexit;
/*
You'll also need to prototype all the functions that will actually
@@ -129,7 +129,7 @@ typedef struct local_info_t {
======================================================================*/
-static int sedlbauer_probe(struct pcmcia_device *link)
+static int __devinit sedlbauer_probe(struct pcmcia_device *link)
{
local_info_t *local;
@@ -177,7 +177,7 @@ static int sedlbauer_probe(struct pcmcia_device *link)
======================================================================*/
-static void sedlbauer_detach(struct pcmcia_device *link)
+static void __devexit sedlbauer_detach(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "sedlbauer_detach(0x%p)\n", link);
@@ -283,7 +283,7 @@ static int sedlbauer_config_check(struct pcmcia_device *p_dev,
-static int sedlbauer_config(struct pcmcia_device *link)
+static int __devinit sedlbauer_config(struct pcmcia_device *link)
{
local_info_t *dev = link->priv;
win_req_t *req;
@@ -441,7 +441,7 @@ static struct pcmcia_driver sedlbauer_driver = {
.name = "sedlbauer_cs",
},
.probe = sedlbauer_probe,
- .remove = sedlbauer_detach,
+ .remove = __devexit_p(sedlbauer_detach),
.id_table = sedlbauer_ids,
.suspend = sedlbauer_suspend,
.resume = sedlbauer_resume,
--
1.6.3.3
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
@ 2010-03-25 12:05 ` Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
2010-03-25 12:14 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Karsten Keil
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
2010-03-25 12:16 ` Wolfram Sang
2 siblings, 2 replies; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-25 12:05 UTC (permalink / raw)
To: isdn; +Cc: davem, linux, akpm, linux-kernel, Henrik Kretzschmar
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.
WARNING: drivers/isdn/hisax/built-in.o(.text+0x56bfb): Section mismatch
in reference from the function teles_cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function teles_cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because teles_cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
drivers/isdn/hisax/teles_cs.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/hisax/teles_cs.c b/drivers/isdn/hisax/teles_cs.c
index b0c5976..d010a0d 100644
--- a/drivers/isdn/hisax/teles_cs.c
+++ b/drivers/isdn/hisax/teles_cs.c
@@ -57,7 +57,7 @@ module_param(protocol, int, 0);
handler.
*/
-static int teles_cs_config(struct pcmcia_device *link);
+static int teles_cs_config(struct pcmcia_device *link) __devinit ;
static void teles_cs_release(struct pcmcia_device *link);
/*
@@ -66,7 +66,7 @@ static void teles_cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/
-static void teles_detach(struct pcmcia_device *p_dev);
+static void teles_detach(struct pcmcia_device *p_dev) __devexit ;
/*
A linked list of "instances" of the teles_cs device. Each actual
@@ -112,7 +112,7 @@ typedef struct local_info_t {
======================================================================*/
-static int teles_probe(struct pcmcia_device *link)
+static int __devinit teles_probe(struct pcmcia_device *link)
{
local_info_t *local;
@@ -156,7 +156,7 @@ static int teles_probe(struct pcmcia_device *link)
======================================================================*/
-static void teles_detach(struct pcmcia_device *link)
+static void __devexit teles_detach(struct pcmcia_device *link)
{
local_info_t *info = link->priv;
@@ -200,7 +200,7 @@ static int teles_cs_configcheck(struct pcmcia_device *p_dev,
return -ENODEV;
}
-static int teles_cs_config(struct pcmcia_device *link)
+static int __devinit teles_cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
@@ -319,7 +319,7 @@ static struct pcmcia_driver teles_cs_driver = {
.name = "teles_cs",
},
.probe = teles_probe,
- .remove = teles_detach,
+ .remove = __devexit_p(teles_detach),
.id_table = teles_ids,
.suspend = teles_suspend,
.resume = teles_resume,
--
1.6.3.3
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
@ 2010-03-25 12:05 ` Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
2010-03-25 12:15 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Karsten Keil
2010-03-25 12:14 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Karsten Keil
1 sibling, 2 replies; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-25 12:05 UTC (permalink / raw)
To: isdn; +Cc: davem, linux, akpm, linux-kernel, Henrik Kretzschmar
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.
WARNING: drivers/isdn/hisax/built-in.o(.text+0x56512): Section mismatch
in reference from the function avma1cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function avma1cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because avma1cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
drivers/isdn/hisax/avma1_cs.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/hisax/avma1_cs.c b/drivers/isdn/hisax/avma1_cs.c
index e5deb15..8d1d63a 100644
--- a/drivers/isdn/hisax/avma1_cs.c
+++ b/drivers/isdn/hisax/avma1_cs.c
@@ -50,7 +50,7 @@ module_param(isdnprot, int, 0);
handler.
*/
-static int avma1cs_config(struct pcmcia_device *link);
+static int avma1cs_config(struct pcmcia_device *link) __devinit ;
static void avma1cs_release(struct pcmcia_device *link);
/*
@@ -59,7 +59,7 @@ static void avma1cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/
-static void avma1cs_detach(struct pcmcia_device *p_dev);
+static void avma1cs_detach(struct pcmcia_device *p_dev) __devexit ;
/*
@@ -99,7 +99,7 @@ typedef struct local_info_t {
======================================================================*/
-static int avma1cs_probe(struct pcmcia_device *p_dev)
+static int __devinit avma1cs_probe(struct pcmcia_device *p_dev)
{
local_info_t *local;
@@ -140,7 +140,7 @@ static int avma1cs_probe(struct pcmcia_device *p_dev)
======================================================================*/
-static void avma1cs_detach(struct pcmcia_device *link)
+static void __devexit avma1cs_detach(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "avma1cs_detach(0x%p)\n", link);
avma1cs_release(link);
@@ -174,7 +174,7 @@ static int avma1cs_configcheck(struct pcmcia_device *p_dev,
}
-static int avma1cs_config(struct pcmcia_device *link)
+static int __devinit avma1cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
@@ -282,7 +282,7 @@ static struct pcmcia_driver avma1cs_driver = {
.name = "avma1_cs",
},
.probe = avma1cs_probe,
- .remove = avma1cs_detach,
+ .remove = __devexit_p(avma1cs_detach),
.id_table = avma1cs_ids,
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
@ 2010-03-25 12:05 ` Henrik Kretzschmar
2010-03-25 12:16 ` Karsten Keil
2010-03-25 12:15 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Karsten Keil
1 sibling, 1 reply; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-25 12:05 UTC (permalink / raw)
To: isdn; +Cc: davem, linux, akpm, linux-kernel, Henrik Kretzschmar
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.
WARNING: drivers/isdn/hisax/built-in.o(.text+0x55e37): Section mismatch
in reference from the function elsa_cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function elsa_cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because elsa_cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
drivers/isdn/hisax/elsa_cs.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/hisax/elsa_cs.c b/drivers/isdn/hisax/elsa_cs.c
index c9a30b1..c9f2279 100644
--- a/drivers/isdn/hisax/elsa_cs.c
+++ b/drivers/isdn/hisax/elsa_cs.c
@@ -76,7 +76,7 @@ module_param(protocol, int, 0);
handler.
*/
-static int elsa_cs_config(struct pcmcia_device *link);
+static int elsa_cs_config(struct pcmcia_device *link) __devinit ;
static void elsa_cs_release(struct pcmcia_device *link);
/*
@@ -85,7 +85,7 @@ static void elsa_cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/
-static void elsa_cs_detach(struct pcmcia_device *p_dev);
+static void elsa_cs_detach(struct pcmcia_device *p_dev) __devexit;
/*
A driver needs to provide a dev_node_t structure for each device
@@ -121,7 +121,7 @@ typedef struct local_info_t {
======================================================================*/
-static int elsa_cs_probe(struct pcmcia_device *link)
+static int __devinit elsa_cs_probe(struct pcmcia_device *link)
{
local_info_t *local;
@@ -166,7 +166,7 @@ static int elsa_cs_probe(struct pcmcia_device *link)
======================================================================*/
-static void elsa_cs_detach(struct pcmcia_device *link)
+static void __devexit elsa_cs_detach(struct pcmcia_device *link)
{
local_info_t *info = link->priv;
@@ -210,7 +210,7 @@ static int elsa_cs_configcheck(struct pcmcia_device *p_dev,
return -ENODEV;
}
-static int elsa_cs_config(struct pcmcia_device *link)
+static int __devinit elsa_cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
@@ -327,7 +327,7 @@ static struct pcmcia_driver elsa_cs_driver = {
.name = "elsa_cs",
},
.probe = elsa_cs_probe,
- .remove = elsa_cs_detach,
+ .remove = __devexit_p(elsa_cs_detach),
.id_table = elsa_ids,
.suspend = elsa_suspend,
.resume = elsa_resume,
--
1.6.3.3
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
@ 2010-03-25 12:13 ` Karsten Keil
2010-03-25 17:02 ` Dominik Brodowski
2010-03-25 18:58 ` David Miller
2010-03-25 12:16 ` Wolfram Sang
2 siblings, 2 replies; 20+ messages in thread
From: Karsten Keil @ 2010-03-25 12:13 UTC (permalink / raw)
To: Henrik Kretzschmar; +Cc: davem, linux, akpm, linux-kernel
On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
> Compiling this driver gave a section mismatch,
> so I reviewed the init/exit paths of the driver
> and made the correct changes.
>
> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
> in reference from the function sedlbauer_config() to the function
> .devinit.text:hisax_init_pcmcia()
> The function sedlbauer_config() references
> the function __devinit hisax_init_pcmcia().
> This is often because sedlbauer_config lacks a __devinit
> annotation or the annotation of hisax_init_pcmcia is wrong.
>
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: <keil@b1-systems.de>
Thank you for fixing this.
l
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
@ 2010-03-25 12:14 ` Karsten Keil
1 sibling, 0 replies; 20+ messages in thread
From: Karsten Keil @ 2010-03-25 12:14 UTC (permalink / raw)
To: Henrik Kretzschmar; +Cc: davem, linux, akpm, linux-kernel
On Donnerstag, 25. März 2010 13:05:30 Henrik Kretzschmar wrote:
> Compiling this driver gave a section mismatch,
> so I reviewed the init/exit paths of the driver
> and made the correct changes.
>
> WARNING: drivers/isdn/hisax/built-in.o(.text+0x56bfb): Section mismatch
> in reference from the function teles_cs_config() to the function
> .devinit.text:hisax_init_pcmcia()
> The function teles_cs_config() references
> the function __devinit hisax_init_pcmcia().
> This is often because teles_cs_config lacks a __devinit
> annotation or the annotation of hisax_init_pcmcia is wrong.
>
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: <keil@b1-systems.de>
Thank you for fixing this.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
@ 2010-03-25 12:15 ` Karsten Keil
1 sibling, 0 replies; 20+ messages in thread
From: Karsten Keil @ 2010-03-25 12:15 UTC (permalink / raw)
To: Henrik Kretzschmar; +Cc: davem, linux, akpm, linux-kernel
On Donnerstag, 25. März 2010 13:05:31 Henrik Kretzschmar wrote:
> Compiling this driver gave a section mismatch,
> so I reviewed the init/exit paths of the driver
> and made the correct changes.
>
> WARNING: drivers/isdn/hisax/built-in.o(.text+0x56512): Section mismatch
> in reference from the function avma1cs_config() to the function
> .devinit.text:hisax_init_pcmcia()
> The function avma1cs_config() references
> the function __devinit hisax_init_pcmcia().
> This is often because avma1cs_config lacks a __devinit
> annotation or the annotation of hisax_init_pcmcia is wrong.
>
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: <keil@b1-systems.de>
Thank you for fixing this.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
@ 2010-03-25 12:16 ` Wolfram Sang
2010-03-25 14:05 ` Henrik Kretzschmar
2010-03-25 14:08 ` Henrik Kretzschmar
2 siblings, 2 replies; 20+ messages in thread
From: Wolfram Sang @ 2010-03-25 12:16 UTC (permalink / raw)
To: Henrik Kretzschmar; +Cc: isdn, davem, linux, akpm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
Hi Henrik,
thanks for the work. Please, just keep the placement of those attributes
consistent. Otherwise it might be easy to miss:
> -static int sedlbauer_config(struct pcmcia_device *link);
> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
Wrong.
> -static int sedlbauer_probe(struct pcmcia_device *link)
> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
> {
Right.
(I think checkpatch checks for this, too)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
@ 2010-03-25 12:16 ` Karsten Keil
0 siblings, 0 replies; 20+ messages in thread
From: Karsten Keil @ 2010-03-25 12:16 UTC (permalink / raw)
To: Henrik Kretzschmar; +Cc: davem, linux, akpm, linux-kernel
On Donnerstag, 25. März 2010 13:05:32 Henrik Kretzschmar wrote:
> Compiling this driver gave a section mismatch,
> so I reviewed the init/exit paths of the driver
> and made the correct changes.
>
> WARNING: drivers/isdn/hisax/built-in.o(.text+0x55e37): Section mismatch
> in reference from the function elsa_cs_config() to the function
> .devinit.text:hisax_init_pcmcia()
> The function elsa_cs_config() references
> the function __devinit hisax_init_pcmcia().
> This is often because elsa_cs_config lacks a __devinit
> annotation or the annotation of hisax_init_pcmcia is wrong.
>
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: <keil@b1-systems.de>
Thank you for fixing this.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 12:16 ` Wolfram Sang
@ 2010-03-25 14:05 ` Henrik Kretzschmar
2010-03-25 14:17 ` Wolfram Sang
2010-03-25 14:08 ` Henrik Kretzschmar
1 sibling, 1 reply; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-25 14:05 UTC (permalink / raw)
To: Wolfram Sang; +Cc: isdn, davem, linux, akpm, linux-kernel
Wolfram Sang schrieb:
> Hi Henrik,
>
> thanks for the work. Please, just keep the placement of those attributes
> consistent. Otherwise it might be easy to miss:
>
>
>> -static int sedlbauer_config(struct pcmcia_device *link);
>> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
>>
>
> Wrong.
>
>
>> -static int sedlbauer_probe(struct pcmcia_device *link)
>> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
>> {
>>
>
> Right.
>
> (I think checkpatch checks for this, too)
>
> Regards,
>
> Wolfram
>
Hi there,
Imho should these functions be reorderd, so that no prototypes are required in a driver file.
If somebody wishes, I would do that for those.
For the prototypes I was following init.h, heres a snippet:
* Usage:
* For functions:
*
* You should add __init immediately before the function name, like:
*
* static void __init initme(int x, int y)
* {
* extern int z; z = x * y;
* }
*
* If the function has a prototype somewhere, you can also add
* __init between closing brace of the prototype and semicolon:
*
* extern int initialize_foobar_device(int, int, int) __init;
*
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 12:16 ` Wolfram Sang
2010-03-25 14:05 ` Henrik Kretzschmar
@ 2010-03-25 14:08 ` Henrik Kretzschmar
1 sibling, 0 replies; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-25 14:08 UTC (permalink / raw)
To: Wolfram Sang; +Cc: isdn, davem, linux, akpm, linux-kernel
Wolfram Sang schrieb:
> Hi Henrik,
>
> thanks for the work. Please, just keep the placement of those attributes
> consistent. Otherwise it might be easy to miss:
>
>
>> -static int sedlbauer_config(struct pcmcia_device *link);
>> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
>>
>
> Wrong.
>
>
>> -static int sedlbauer_probe(struct pcmcia_device *link)
>> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
>> {
>>
>
> Right.
>
> (I think checkpatch checks for this, too)
No, checkpatch doesn't claim about that.
Greets, Henrik
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 14:05 ` Henrik Kretzschmar
@ 2010-03-25 14:17 ` Wolfram Sang
0 siblings, 0 replies; 20+ messages in thread
From: Wolfram Sang @ 2010-03-25 14:17 UTC (permalink / raw)
To: Henrik Kretzschmar; +Cc: isdn, davem, linux, akpm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
> Imho should these functions be reorderd, so that no prototypes are required
> in a driver file. If somebody wishes, I would do that for those.
I stand corrected, missed that for prototypes. Sorry for the noise.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
@ 2010-03-25 17:02 ` Dominik Brodowski
2010-03-25 18:45 ` David Miller
2010-03-25 18:58 ` David Miller
1 sibling, 1 reply; 20+ messages in thread
From: Dominik Brodowski @ 2010-03-25 17:02 UTC (permalink / raw)
To: Karsten Keil; +Cc: Henrik Kretzschmar, davem, akpm, linux-kernel
Karsten, will you carry these fixes upstream, or shall I do?
Best,
Dominik
On Thu, Mar 25, 2010 at 01:13:18PM +0100, Karsten Keil wrote:
> On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
> > Compiling this driver gave a section mismatch,
> > so I reviewed the init/exit paths of the driver
> > and made the correct changes.
> >
> > WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
> > in reference from the function sedlbauer_config() to the function
> > .devinit.text:hisax_init_pcmcia()
> > The function sedlbauer_config() references
> > the function __devinit hisax_init_pcmcia().
> > This is often because sedlbauer_config lacks a __devinit
> > annotation or the annotation of hisax_init_pcmcia is wrong.
> >
> > Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> Acked-by: <keil@b1-systems.de>
>
> Thank you for fixing this.
> l
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 17:02 ` Dominik Brodowski
@ 2010-03-25 18:45 ` David Miller
2010-03-25 18:55 ` David Miller
0 siblings, 1 reply; 20+ messages in thread
From: David Miller @ 2010-03-25 18:45 UTC (permalink / raw)
To: linux; +Cc: isdn, henne, akpm, linux-kernel
From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: Thu, 25 Mar 2010 18:02:40 +0100
> Karsten, will you carry these fixes upstream, or shall I do?
I'll apply them.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 18:45 ` David Miller
@ 2010-03-25 18:55 ` David Miller
0 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2010-03-25 18:55 UTC (permalink / raw)
To: linux; +Cc: isdn, henne, akpm, linux-kernel
From: David Miller <davem@davemloft.net>
Date: Thu, 25 Mar 2010 11:45:48 -0700 (PDT)
> From: Dominik Brodowski <linux@dominikbrodowski.net>
> Date: Thu, 25 Mar 2010 18:02:40 +0100
>
>> Karsten, will you carry these fixes upstream, or shall I do?
>
> I'll apply them.
BTW, please CC: netdev on ISDN patches in the future.
I'll add some material to the MAINTAINERS if there isn't
a mention about this there already.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
2010-03-25 17:02 ` Dominik Brodowski
@ 2010-03-25 18:58 ` David Miller
2010-03-26 0:59 ` Henrik Kretzschmar
1 sibling, 1 reply; 20+ messages in thread
From: David Miller @ 2010-03-25 18:58 UTC (permalink / raw)
To: isdn; +Cc: henne, linux, akpm, linux-kernel
From: Karsten Keil <isdn@linux-pingi.de>
Date: Thu, 25 Mar 2010 13:13:18 +0100
> On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
>> Compiling this driver gave a section mismatch,
>> so I reviewed the init/exit paths of the driver
>> and made the correct changes.
>>
>> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
>> in reference from the function sedlbauer_config() to the function
>> .devinit.text:hisax_init_pcmcia()
>> The function sedlbauer_config() references
>> the function __devinit hisax_init_pcmcia().
>> This is often because sedlbauer_config lacks a __devinit
>> annotation or the annotation of hisax_init_pcmcia is wrong.
>>
>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> Acked-by: <keil@b1-systems.de>
>
> Thank you for fixing this.
Thanks for reviewing Karsten.
Please put your proper name in your ACK lines in the
future, they should look just like Signed-off-by: lines.
I fixed this up when committing, thanks again.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-25 18:58 ` David Miller
@ 2010-03-26 0:59 ` Henrik Kretzschmar
2010-03-26 3:27 ` David Miller
0 siblings, 1 reply; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-26 0:59 UTC (permalink / raw)
To: David Miller; +Cc: isdn, linux, akpm, linux-kernel
David Miller schrieb:
> From: Karsten Keil <isdn@linux-pingi.de>
> Date: Thu, 25 Mar 2010 13:13:18 +0100
>
>
>> On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
>>
>>> Compiling this driver gave a section mismatch,
>>> so I reviewed the init/exit paths of the driver
>>> and made the correct changes.
>>>
>>> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
>>> in reference from the function sedlbauer_config() to the function
>>> .devinit.text:hisax_init_pcmcia()
>>> The function sedlbauer_config() references
>>> the function __devinit hisax_init_pcmcia().
>>> This is often because sedlbauer_config lacks a __devinit
>>> annotation or the annotation of hisax_init_pcmcia is wrong.
>>>
>>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
>>>
>> Acked-by: <keil@b1-systems.de>
>>
>> Thank you for fixing this.
>>
>
> Thanks for reviewing Karsten.
>
> Please put your proper name in your ACK lines in the
> future, they should look just like Signed-off-by: lines.
>
> I fixed this up when committing, thanks again.
>
>
Hi David,
I've seen that you put the patches on the net-tree. Thats fine.
In the author field my real name "Henrik Kretzschmar" was replaced by "Henne" somehow.
That's not a problem for me, but I just wanted to have you noticed about that.
Greets Henrik
P.S. cc-ing to netdev is okay.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-26 0:59 ` Henrik Kretzschmar
@ 2010-03-26 3:27 ` David Miller
2010-03-26 13:56 ` Henrik Kretzschmar
0 siblings, 1 reply; 20+ messages in thread
From: David Miller @ 2010-03-26 3:27 UTC (permalink / raw)
To: henne; +Cc: isdn, linux, akpm, linux-kernel
From: Henrik Kretzschmar <henne@nachtwindheim.de>
Date: Fri, 26 Mar 2010 01:59:07 +0100
> I've seen that you put the patches on the net-tree. Thats fine. In
> the author field my real name "Henrik Kretzschmar" was replaced by
> "Henne" somehow. That's not a problem for me, but I just wanted to
> have you noticed about that
That's what the From: fields were in your patch postings are
recorded by patchwork.kernel.org
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-26 3:27 ` David Miller
@ 2010-03-26 13:56 ` Henrik Kretzschmar
2010-03-26 16:46 ` David Miller
0 siblings, 1 reply; 20+ messages in thread
From: Henrik Kretzschmar @ 2010-03-26 13:56 UTC (permalink / raw)
To: David Miller; +Cc: isdn, linux, akpm, linux-kernel
David Miller schrieb:
> From: Henrik Kretzschmar <henne@nachtwindheim.de>
> Date: Fri, 26 Mar 2010 01:59:07 +0100
>
>
>> I've seen that you put the patches on the net-tree. Thats fine. In
>> the author field my real name "Henrik Kretzschmar" was replaced by
>> "Henne" somehow. That's not a problem for me, but I just wanted to
>> have you noticed about that
>>
>
> That's what the From: fields were in your patch postings are
> recorded by patchwork.kernel.org
>
>
Strange! When you click at the "show" link on
https://patchwork.kernel.org/patch/88203/
you'll see, that the my name is right in the From: field.
But on the whole site I'm reffered as "Henne".
And I quiet can't figure out if I like that patchwork give me animal
names. :)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
2010-03-26 13:56 ` Henrik Kretzschmar
@ 2010-03-26 16:46 ` David Miller
0 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2010-03-26 16:46 UTC (permalink / raw)
To: henne; +Cc: isdn, linux, akpm, linux-kernel
From: Henrik Kretzschmar <henne@nachtwindheim.de>
Date: Fri, 26 Mar 2010 14:56:33 +0100
> And I quiet can't figure out if I like that patchwork give me animal
> names. :)
When you submit future patches, I'll make sure this doesn't happen
again.
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2010-03-26 16:46 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
2010-03-25 12:16 ` Karsten Keil
2010-03-25 12:15 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Karsten Keil
2010-03-25 12:14 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Karsten Keil
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
2010-03-25 17:02 ` Dominik Brodowski
2010-03-25 18:45 ` David Miller
2010-03-25 18:55 ` David Miller
2010-03-25 18:58 ` David Miller
2010-03-26 0:59 ` Henrik Kretzschmar
2010-03-26 3:27 ` David Miller
2010-03-26 13:56 ` Henrik Kretzschmar
2010-03-26 16:46 ` David Miller
2010-03-25 12:16 ` Wolfram Sang
2010-03-25 14:05 ` Henrik Kretzschmar
2010-03-25 14:17 ` Wolfram Sang
2010-03-25 14:08 ` Henrik Kretzschmar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox